gitweb: pull ref markes pull out of subject <a> element

Since 4afbaef (gitweb: ref markers link to named shortlogs, 2008-09-02), ref markers that accompany the subject in views such as shortlog and history point to something different from the subject itself. Therefore, they should not be included in the same <a> element. Benefits of the change are: * better compliance to the XHTML standards, that forbid links within links even though the restriction cannot be imposed via DTD; this also benefits visualization in some older browsers; * when hovering the subject, only the subject itself is underlined; when hovering the ref markers, only the text in the hovered ref marker is underlined; previously, hovering any written part of the subject column led to complete underlying of everything at the same time, with unpleasing effects. Signed-off-by: Giuseppe Bilotta <giuseppe.bilotta@gmail.com> Acked-by: Jakub Narebski <jnareb@gmail.com> Signed-off-by: Junio C Hamano <gitster@pobox.com>

Giuseppe Bilotta committed Aug 23, 2009 at 10:28 UTC 01b89f0cd5d1c36990bbd3595b7d54c5f67d01e3

1 file changed +2 -2

gitweb/gitweb.perl

+2 -2

@@ -1513,10 +1513,10 @@ sub format_subject_html {

1513 $long =~ s/[[:cntrl:]]/?/g;

1514 return $cgi->a({-href => $href, -class => "list subject",

1515 -title => to_utf8($long)},

1516 - esc_html($short) . $extra);

1516 + esc_html($short)) . $extra;

1517 } else {

1518 return $cgi->a({-href => $href, -class => "list subject"},

1519 - esc_html($long) . $extra);

1519 + esc_html($long)) . $extra;

1520 }

1521 }

1522