mmap_limit: introduce GIT_MMAP_LIMIT to allow testing expected mmap size
In order to test expectations about mmap in a way similar to testing expectations about malloc with GIT_ALLOC_LIMIT introduced by d41489a6 (Add more large blob test cases, 2012-03-07), introduce a new environment variable GIT_MMAP_LIMIT to limit the largest allowed mmap length. xmmap() is modified to check the size of the requested region and fail it if it is beyond the limit. Together with GIT_ALLOC_LIMIT tests can now confirm expectations about memory consumption. Signed-off-by: Steffen Prohaska <prohaska@zib.de> Signed-off-by: Junio C Hamano <gitster@pobox.com>
Steffen Prohaska committed
Aug 26, 2014 at 17:23 UTC
02710228dd79d9f9c6fa180233491639b603c06d
1 file changed
+17
-1
sha1_file.c
+17
-1
@@ -663,10 +663,26 @@ void release_pack_memory(size_t need)
663
; /* nothing */
664
}
665
666
+static void mmap_limit_check(size_t length)
667
+{
668
+ static size_t limit = 0;
669
+ if (!limit) {
670
+ limit = git_env_ulong("GIT_MMAP_LIMIT", 0);
671
+ if (!limit)
672
+ limit = SIZE_MAX;
673
+ }
674
+ if (length > limit)
675
+ die("attempting to mmap %"PRIuMAX" over limit %"PRIuMAX,
676
+ (uintmax_t)length, (uintmax_t)limit);
677
+}
678
+
679
void *xmmap(void *start, size_t length,
680
int prot, int flags, int fd, off_t offset)
681
{
669
- void *ret = mmap(start, length, prot, flags, fd, offset);
682
+ void *ret;
683
+
684
+ mmap_limit_check(length);
685
+ ret = mmap(start, length, prot, flags, fd, offset);
686
if (ret == MAP_FAILED) {
687
if (!length)
688
return NULL;