http-backend: enable cleaning up forked upload/receive-pack on exit
If http-backend dies because of errors, started upload-pack or receive-pack are not killed and waited, but rather stay running for some time until they exit because of closed stdin. It may be undesirable in working environment, and it also causes occasional failure of t5562, because the processes keep opened act.err, and sometimes write there errors after next test started using the file. Fix by enabling cleaning of the command at http-backed exit. Reported-by: Carlo Arenas <carenas@gmail.com> Helped-by: Carlo Arenas <carenas@gmail.com> Signed-off-by: Max Kirillov <max@max630.net> Signed-off-by: Junio C Hamano <gitster@pobox.com>
Max Kirillov committed
Nov 24, 2018 at 15:48 UTC
02818a98d7bddbc036fe6a1ceea847c6de20ed00
1 file changed
+2
http-backend.c
+2
@@ -486,6 +486,8 @@ static void run_service(const char **argv, int buffer_input)
486
if (buffer_input || gzipped_request || req_len >= 0)
487
cld.in = -1;
488
cld.git_cmd = 1;
489
+ cld.clean_on_exit = 1;
490
+ cld.wait_after_clean = 1;
491
if (start_command(&cld))
492
exit(1);
493