bisect--helper: retire `--next-all` subcommand
The `--next-all` subcommand is no longer used from the git-bisect.sh shell script. Instead the function `bisect_next_all()` is called from the C implementation of `bisect_next()`. Mentored-by: Lars Schneider <larsxschneider@gmail.com> Mentored-by: Christian Couder <chriscool@tuxfamily.org> Signed-off-by: Pranit Bauva <pranit.bauva@gmail.com> Signed-off-by: Tanushree Tumane <tanushreetumane@gmail.com> Signed-off-by: Miriam Rubio <mirucam@gmail.com> Reviewed-by: Johannes Schindelin <johannes.schindelin@gmx.de> Signed-off-by: Junio C Hamano <gitster@pobox.com>
Pranit Bauva committed
Oct 15, 2020 at 15:38 UTC
04774b4e7090e6b418ab053a6d4412a665cae703
1 file changed
+1
-8
builtin/bisect--helper.c
+1
-8
@@ -20,7 +20,6 @@ static GIT_PATH_FUNC(git_path_bisect_names, "BISECT_NAMES")
20
static GIT_PATH_FUNC(git_path_bisect_first_parent, "BISECT_FIRST_PARENT")
21
22
static const char * const git_bisect_helper_usage[] = {
23
- N_("git bisect--helper --next-all"),
23
N_("git bisect--helper --write-terms <bad_term> <good_term>"),
24
N_("git bisect--helper --bisect-reset [<commit>]"),
25
N_("git bisect--helper --bisect-write [--no-log] <state> <revision> <good_term> <bad_term>"),
@@ -859,8 +858,7 @@ static int bisect_autostart(struct bisect_terms *terms)
858
int cmd_bisect__helper(int argc, const char **argv, const char *prefix)
859
{
860
enum {
862
- NEXT_ALL = 1,
863
- WRITE_TERMS,
861
+ WRITE_TERMS = 1,
862
CHECK_EXPECTED_REVS,
863
BISECT_RESET,
864
BISECT_WRITE,
@@ -874,8 +872,6 @@ int cmd_bisect__helper(int argc, const char **argv, const char *prefix)
872
} cmdmode = 0;
873
int res = 0, nolog = 0;
874
struct option options[] = {
877
- OPT_CMDMODE(0, "next-all", &cmdmode,
878
- N_("perform 'git bisect next'"), NEXT_ALL),
875
OPT_CMDMODE(0, "write-terms", &cmdmode,
876
N_("write the terms to .git/BISECT_TERMS"), WRITE_TERMS),
877
OPT_CMDMODE(0, "check-expected-revs", &cmdmode,
@@ -912,9 +908,6 @@ int cmd_bisect__helper(int argc, const char **argv, const char *prefix)
908
usage_with_options(git_bisect_helper_usage, options);
909
910
switch (cmdmode) {
915
- case NEXT_ALL:
916
- res = bisect_next_all(the_repository, prefix);
917
- break;
911
case WRITE_TERMS:
912
if (argc != 2)
913
return error(_("--write-terms requires two arguments"));