@matheusbsbs / matheus-bagliano / commits / 0497c620ca
Fork 0

shortlog: prompt when reading from terminal by mistake

I was trying to see who have been active recently to find GSoC mentor candidates by running: $ git shortlog -s -n --since=4.months | head -n 20 After waiting for about 20 seconds, I started getting worried, thinking that the recent revision traversal updates might have had an unintended side effect. Not so. "git shortlog" acts as a filter when no revs are given, unlike "git log" which defaults to HEAD. It was reading from its standard input. Signed-off-by: Junio C Hamano <junkio@cox.net>

Junio C Hamano committed Mar 8, 2007 at 02:12 UTC 0497c620cae0531815afc4ada783b488eab3f447
1 file changed +4 -1
builtin-shortlog.c
+4 -1
@@ -304,8 +304,11 @@ int cmd_shortlog(int argc, const char **argv, const char *prefix)
304 if (!access(".mailmap", R_OK))
305 read_mailmap(".mailmap");
306
307 - if (rev.pending.nr == 0)
307 + if (rev.pending.nr == 0) {
308 + if (isatty(0))
309 + fprintf(stderr, "(reading log to summarize from standard input)\n");
310 read_from_stdin(&list);
311 + }
312 else
313 get_from_rev(&rev, &list);
314