diff-highlight: check diff-highlight exit status in tests
When testing diff-highlight, we pipe the output through a sanitizing function. This loses the exit status of diff-highlight itself, which could mean we are missing cases where it crashes or exits unexpectedly. Use an extra tempfile to avoid the pipe. Signed-off-by: Jeff King <peff@peff.net> Signed-off-by: Junio C Hamano <gitster@pobox.com>
Jeff King committed
Mar 23, 2026 at 02:02 UTC
05002f60565cdfe2b86108c7f7c027a41d534140
1 file changed
+4
-2
contrib/diff-highlight/t/t9400-diff-highlight.sh
+4
-2
@@ -41,8 +41,10 @@ dh_test () {
41
git show >commit.raw
42
} >/dev/null &&
43
44
- "$DIFF_HIGHLIGHT" <diff.raw | test_strip_patch_header >diff.act &&
45
- "$DIFF_HIGHLIGHT" <commit.raw | test_strip_patch_header >commit.act &&
44
+ "$DIFF_HIGHLIGHT" <diff.raw >diff.hi &&
45
+ test_strip_patch_header <diff.hi >diff.act &&
46
+ "$DIFF_HIGHLIGHT" <commit.raw >commit.hi &&
47
+ test_strip_patch_header <commit.hi >commit.act &&
48
test_cmp patch.exp diff.act &&
49
test_cmp patch.exp commit.act
50
}