log: fix a memory leak in "git show <revision>..."
Fix a memory leak in code added in 5d7eeee2ac6 (git-show: grok blobs,
trees and tags, too, 2006-12-14). As we iterate over a "<revision>..."
command-line and encounter ad OBJ_COMMIT we want to use our "struct
rev_info", but with a "pending" array of one element: the one commit
we're showing in the loop.
To do this 5d7eeee2ac6 saved away a pointer to rev.pending.objects and
rev.pending.nr for its iteration. We'd then clobber those (and alloc)
when we needed to show an OBJ_COMMIT.
We'd therefore leak the "rev.pending" we started out with, and only
free the new "rev.pending" in the "OBJ_COMMIT" case arm as
prepare_revision_walk() would draw it down.
Let's fix this memory leak. Now when we encounter an OBJ_COMMIT we
save away the "rev.pending" before clearing it. We then add a single
commit to it, which our indirect invocation of prepare_revision_walk()
will remove. After that we restore the "rev.pending".
Our "rev.pending" will then get free'd by the release_revisions()
added in f6bfea0ad01 (revisions API users: use release_revisions() in
builtin/log.c, 2022-04-13)
Signed-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
Ævar Arnfjörð Bjarmason committedAug 2, 2022 at 17:33 UTC055e57b7b2183cd5ae7ce8af0becd20623b3db71
index 0ce1f22eff..86cff324ff 100755--- a/t/t0203-gettext-setlocale-sanity.sh+++ b/t/t0203-gettext-setlocale-sanity.sh@@ -5,6 +5,7 @@ test_description="The Git C functions aren't broken by setlocale(3)"+TEST_PASSES_SANITIZE_LEAK=true . ./lib-gettext.sh test_expect_success 'git show a ISO-8859-1 commit under C locale' '
t/t1020-subdirectory.sh
+1
index 9fdbb2af80..45eef9457f 100755--- a/t/t1020-subdirectory.sh+++ b/t/t1020-subdirectory.sh@@ -6,6 +6,7 @@ test_description='Try various core-level commands in subdirectory. '+TEST_PASSES_SANITIZE_LEAK=true . ./test-lib.sh . "$TEST_DIRECTORY"/lib-read-tree.sh
t/t3307-notes-man.sh
+1
index 1aa366a410..ae316502c4 100755--- a/t/t3307-notes-man.sh+++ b/t/t3307-notes-man.sh@@ -4,6 +4,7 @@ test_description='Examples from the git-notes man page Make sure the manual is not full of lies.'+TEST_PASSES_SANITIZE_LEAK=true . ./test-lib.sh test_expect_success 'setup' '
t/t3920-crlf-messages.sh
+2
index 0276edbe3d..4c661d4d54 100755--- a/t/t3920-crlf-messages.sh+++ b/t/t3920-crlf-messages.sh@@ -1,6 +1,8 @@ #!/bin/sh test_description='Test ref-filter and pretty APIs for commit and tag messages using CRLF'++TEST_PASSES_SANITIZE_LEAK=true . ./test-lib.sh LIB_CRLF_BRANCHES=""
t/t4069-remerge-diff.sh
+1
index 35f94957fc..9e7cac68b1 100755--- a/t/t4069-remerge-diff.sh+++ b/t/t4069-remerge-diff.sh@@ -2,6 +2,7 @@ test_description='remerge-diff handling'+TEST_PASSES_SANITIZE_LEAK=true . ./test-lib.sh # This test is ort-specific