config: use git_parse_int() in git_config_get_expiry_in_days()
git_config_get_expiry_in_days() calls git_parse_signed() with the maximum value of int, which is equivalent to calling git_parse_int(). Do that instead, as its shorter and clearer. This requires demoting "days" to int to match. Promote "scale" to intmax_t in turn to arrive at the same result when multiplying them. Signed-off-by: René Scharfe <l.s.r@web.de> Signed-off-by: Junio C Hamano <gitster@pobox.com>
René Scharfe committed
Dec 27, 2025 at 10:29 UTC
06188ea5f3f14040eb01aa883ac7a7a03c93e6a2
1 file changed
+3
-3
config.c
+3
-3
@@ -2434,14 +2434,14 @@ int repo_config_get_expiry_in_days(struct repository *r, const char *key,
2434
timestamp_t *expiry, timestamp_t now)
2435
{
2436
const char *expiry_string;
2437
- intmax_t days;
2437
+ int days;
2438
timestamp_t when;
2439
2440
if (repo_config_get_string_tmp(r, key, &expiry_string))
2441
return 1; /* no such thing */
2442
2443
- if (git_parse_signed(expiry_string, &days, maximum_signed_value_of_type(int))) {
2444
- const int scale = 86400;
2443
+ if (git_parse_int(expiry_string, &days)) {
2444
+ const intmax_t scale = 86400;
2445
*expiry = now - days * scale;
2446
return 0;
2447
}