clone: Fix error message for reference repository

Do not report that an argument to clone's --reference option is not a local directory. Nothing checks for the existence or type of the path as supplied by the user; checks are only done for particular contents of the supposed directory, so we have no way to know the status of the supplied path. Telling the user that a directory doesn't exist when that isn't actually known may lead him or her on the wrong path to finding the problem. Instead just state that the entered path is not a local repository which is really all that is known about it. It could be more helpful to state the actual paths which were checked, but I believe that giving a good description of that would be too verbose for a simple error message and would be too dependent on implementation details. Signed-off-by: Aaron Schrab <aaron@schrab.com> Reviewed-by: Jonathan Nieder <jrnieder@gmail.com> Signed-off-by: Junio C Hamano <gitster@pobox.com>

Aaron Schrab committed Apr 8, 2013 at 18:46 UTC 0658569eb03e743ef46abd06abd9d0d81d53e72c
1 file changed +1 -1
builtin/clone.c
+1 -1
@@ -241,7 +241,7 @@ static int add_one_reference(struct string_list_item *item, void *cb_data)
241 free(ref_git);
242 ref_git = ref_git_git;
243 } else if (!is_directory(mkpath("%s/objects", ref_git)))
244 - die(_("reference repository '%s' is not a local directory."),
244 + die(_("reference repository '%s' is not a local repository."),
245 item->string);
246
247 strbuf_addf(&alternate, "%s/objects", ref_git);