parse-options.[ch]: revert use of "enum" for parse_options()
Revert the parse_options() prototype change in my recent 352e761388b (parse-options.[ch]: consistently use "enum parse_opt_result", 2021-10-08) was incorrect. The parse_options() function returns the number of argc elements that haven't been processed, not "enum parse_opt_result". Reported-by: SZEDER Gábor <szeder.dev@gmail.com> Signed-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com> Signed-off-by: Junio C Hamano <gitster@pobox.com>
Ævar Arnfjörð Bjarmason committed
Nov 9, 2021 at 12:04 UTC
06a199f38b50ccea198c29216c69bb389ca23391
2 files changed
+9
-10
parse-options.c
+5
-5
@@ -860,11 +860,11 @@ int parse_options_end(struct parse_opt_ctx_t *ctx)
860
return ctx->cpidx + ctx->argc;
861
}
862
863
-enum parse_opt_result parse_options(int argc, const char **argv,
864
- const char *prefix,
865
- const struct option *options,
866
- const char * const usagestr[],
867
- enum parse_opt_flags flags)
863
+int parse_options(int argc, const char **argv,
864
+ const char *prefix,
865
+ const struct option *options,
866
+ const char * const usagestr[],
867
+ enum parse_opt_flags flags)
868
{
869
struct parse_opt_ctx_t ctx;
870
struct option *real_options;
parse-options.h
+4
-5
@@ -211,11 +211,10 @@ struct option {
211
* untouched and parse_options() returns the number of options
212
* processed.
213
*/
214
-enum parse_opt_result parse_options(int argc, const char **argv,
215
- const char *prefix,
216
- const struct option *options,
217
- const char * const usagestr[],
218
- enum parse_opt_flags flags);
214
+int parse_options(int argc, const char **argv, const char *prefix,
215
+ const struct option *options,
216
+ const char * const usagestr[],
217
+ enum parse_opt_flags flags);
218
219
NORETURN void usage_with_options(const char * const *usagestr,
220
const struct option *options);