@matheusbsbs / matheus-bagliano / commits / 071fa89e25
Fork 0

git-fsck-objects: lacking default references should not be fatal

The comment added says it all: if we have lost all references in a git archive, git-fsck-objects should still work, so instead of dying it should just notify the user about that condition. This change was triggered by me just doing a "git-init-db" and then populating that empty git archive with a pack/index file to look at it. Having git-fsck-objects not work just because I didn't have any references handy was rather irritating, since part of the reason for running git-fsck-objects in the first place was to _find_ the missing references. However, "--unreachable" really doesn't make sense in that situation, and we want to turn it off to protect anybody who uses the old "git prune" shell-script (rather than the modern built-in). The old pruning script used to remove all objects that were reported as unreachable, and without any refs, that obviously means everything - not worth it. Signed-off-by: Linus Torvalds <torvalds@osdl.org> Signed-off-by: Junio C Hamano <junkio@cox.net>

Linus Torvalds committed Aug 29, 2006 at 11:47 UTC 071fa89e25855a746728b835359eb263c7c7ee7f
1 file changed +17 -2
fsck-objects.c
+17 -2
@@ -425,8 +425,23 @@ static int fsck_handle_ref(const char *refname, const unsigned char *sha1)
425 static void get_default_heads(void)
426 {
427 for_each_ref(fsck_handle_ref);
428 - if (!default_refs)
429 - die("No default references");
428 +
429 + /*
430 + * Not having any default heads isn't really fatal, but
431 + * it does mean that "--unreachable" no longer makes any
432 + * sense (since in this case everything will obviously
433 + * be unreachable by definition.
434 + *
435 + * Showing dangling objects is valid, though (as those
436 + * dangling objects are likely lost heads).
437 + *
438 + * So we just print a warning about it, and clear the
439 + * "show_unreachable" flag.
440 + */
441 + if (!default_refs) {
442 + error("No default references");
443 + show_unreachable = 0;
444 + }
445 }
446
447 static void fsck_object_dir(const char *path)