branch: fix segfault when resolving an invalid HEAD
Caused by return value of resolve_ref being passed directly to xstrdup whereby the sanity checking was never reached. Signed-off-by: Jonas Fonseca <fonseca@diku.dk> Signed-off-by: Junio C Hamano <junkio@cox.net>
Jonas Fonseca committed
May 20, 2007 at 14:19 UTC
078f8380f65acfdffee077a642e982453277873a
1 file changed
+2
-1
builtin-branch.c
+2
-1
@@ -623,9 +623,10 @@ int cmd_branch(int argc, const char **argv, const char *prefix)
623
(rename && force_create))
624
usage(builtin_branch_usage);
625
626
- head = xstrdup(resolve_ref("HEAD", head_sha1, 0, NULL));
626
+ head = resolve_ref("HEAD", head_sha1, 0, NULL);
627
if (!head)
628
die("Failed to resolve HEAD as a valid ref.");
629
+ head = xstrdup(head);
630
if (!strcmp(head, "HEAD")) {
631
detached = 1;
632
}