t5612: don't use `test_must_fail test_cmp`
The test_must_fail function should only be used for git commands since we should assume that external commands work sanely. Since test_cmp() just wraps an external command, replace `test_must_fail test_cmp` with `! test_cmp`. Signed-off-by: Denton Liu <liu.denton@gmail.com> Signed-off-by: Junio C Hamano <gitster@pobox.com>
Denton Liu committed
Mar 26, 2020 at 04:27 UTC
0813dd28b948787ed61b3052d36043d9a8348edc
1 file changed
+1
-1
t/t5612-clone-refspec.sh
+1
-1
@@ -87,7 +87,7 @@ test_expect_success 'by default no tags will be kept updated' '
87
git for-each-ref refs/tags >../actual
88
) &&
89
git for-each-ref refs/tags >expect &&
90
- test_must_fail test_cmp expect actual &&
90
+ ! test_cmp expect actual &&
91
test_line_count = 2 actual
92
'
93