@matheusbsbs / matheus-bagliano / commits / 0a34594c83

fast-import: Fix an gcc -Wuninitialized warning

Commit cbfd5e1c ("drop some obsolete "x = x" compiler warning hacks", 21-03-2013) removed a gcc hack that suppressed an "might be used uninitialized" warning issued by older versions of gcc. However, commit 3aa99df8 ('fast-import: clarify "inline" logic in file_change_m', 21-03-2013) addresses an (almost) identical issue (with very similar code), but includes additional code in it's resolution. The solution used by this commit, unlike that used by commit cbfd5e1c, also suppresses the -Wuninitialized warning on older versions of gcc. In order to suppress the warning (against the 'oe' symbol) in the note_change_n() function, we adopt the same solution used by commit 3aa99df8. Signed-off-by: Ramsay Jones <ramsay@ramsay1.demon.co.uk> Signed-off-by: Junio C Hamano <gitster@pobox.com>

Ramsay Jones committed Mar 26, 2013 at 19:09 UTC 0a34594c8340f5cf246592ec08d330901ea8951e
1 file changed +1
fast-import.c
+1
@@ -2465,6 +2465,7 @@ static void note_change_n(struct branch *b, unsigned char *old_fanout)
2465 hashcpy(sha1, oe->idx.sha1);
2466 } else if (!prefixcmp(p, "inline ")) {
2467 inline_data = 1;
2468 + oe = NULL; /* not used with inline_data, but makes gcc happy */
2469 p += strlen("inline"); /* advance to space */
2470 } else {
2471 if (get_sha1_hex(p, sha1))