smart-http: document flush after "# service" line
The http-protocol.txt spec fails to mention that a flush packet comes in the smart server response after sending the "service" header. Technically the client code is actually ready to receive an arbitrary number of headers here, but since we haven't introduced any other headers in the past decade (and the client would just throw them away), let's not mention it in the spec. This fixes both BNF and the example. While we're fixing the latter, let's also add the missing flush after the ref list. Reported-by: Dorian Taylor <dorian.taylor.lists@gmail.com> Signed-off-by: Jeff King <peff@peff.net> Signed-off-by: Junio C Hamano <gitster@pobox.com>
Jeff King committed
Mar 3, 2018 at 00:27 UTC
0aa7a780995d3bbef4524a2cdc2e5d33cca56fa9
1 file changed
+3
Documentation/technical/http-protocol.txt
+3
@@ -214,10 +214,12 @@ smart server reply:
214
S: Cache-Control: no-cache
215
S:
216
S: 001e# service=git-upload-pack\n
217
+ S: 0000
218
S: 004895dcfa3633004da0049d3d0fa03f80589cbcaf31 refs/heads/maint\0multi_ack\n
219
S: 0042d049f6c27a2244e12041955e262a404c7faba355 refs/heads/master\n
220
S: 003c2cb58b79488a98d2721cea644875a8dd0026b115 refs/tags/v1.0\n
221
S: 003fa3c2e2402b99163d1d59756e5f207ae21cccba4c refs/tags/v1.0^{}\n
222
+ S: 0000
223
224
The client may send Extra Parameters (see
225
Documentation/technical/pack-protocol.txt) as a colon-separated string
@@ -277,6 +279,7 @@ The returned response contains "version 1" if "version=1" was sent as an
279
Extra Parameter.
280
281
smart_reply = PKT-LINE("# service=$servicename" LF)
282
+ "0000"
283
*1("version 1")
284
ref_list
285
"0000"