fetch_bundle_uri(): drop pointless NULL check
We check if "uri" is NULL, but it cannot be since we'd have segfaulted earlier in the function when we unconditionally called xstrdup() on it. In theory we might want to soften that xstrdup() to handle this case, but even before the code which added it via c23f592117 (bundle-uri: fetch a list of bundles, 2022-10-12), we'd have fed NULL to fetch_bundle_uri_internal(), which would also segfault. The extra check isn't hurting anything, but it does cause Coverity to complain, and it may mislead somebody reading the code into thinking that a NULL uri is something we're prepared to handle. Signed-off-by: Jeff King <peff@peff.net> Signed-off-by: Junio C Hamano <gitster@pobox.com>
Jeff King committed
Apr 22, 2023 at 09:56 UTC
0b1a95ef793716e7e51caf929b971ee2cbf4116d
1 file changed
+2
-2
bundle-uri.c
+2
-2
@@ -795,10 +795,10 @@ int fetch_bundle_uri(struct repository *r, const char *uri,
795
init_bundle_list(&list);
796
797
/*
798
- * Do not fetch a NULL or empty bundle URI. An empty bundle URI
798
+ * Do not fetch an empty bundle URI. An empty bundle URI
799
* could signal that a configured bundle URI has been disabled.
800
*/
801
- if (!uri || !*uri) {
801
+ if (!*uri) {
802
result = 0;
803
goto cleanup;
804
}