commit.c: free() revs.commit in get_fork_point()
Fix a memory leak that's been with us since d96855ff517 (merge-base: teach "--fork-point" mode, 2013-10-23). Signed-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com> Signed-off-by: Junio C Hamano <gitster@pobox.com>
Ævar Arnfjörð Bjarmason committed
Feb 6, 2023 at 20:08 UTC
0c10ed19c4806e9a75e63fd5185d4d4c15f99c63
3 files changed
+3
commit.c
+1
@@ -1033,6 +1033,7 @@ struct commit *get_fork_point(const char *refname, struct commit *commit)
1033
ret = bases->item;
1034
1035
cleanup_return:
1036
+ free(revs.commit);
1037
free_commit_list(bases);
1038
free(full_refname);
1039
return ret;
t/t3431-rebase-fork-point.sh
+1
@@ -8,6 +8,7 @@ test_description='git rebase --fork-point test'
8
GIT_TEST_DEFAULT_INITIAL_BRANCH_NAME=main
9
export GIT_TEST_DEFAULT_INITIAL_BRANCH_NAME
10
11
+TEST_PASSES_SANITIZE_LEAK=true
12
. ./test-lib.sh
13
14
# A---B---D---E (main)
t/t3432-rebase-fast-forward.sh
+1
@@ -8,6 +8,7 @@ test_description='ensure rebase fast-forwards commits when possible'
8
GIT_TEST_DEFAULT_INITIAL_BRANCH_NAME=main
9
export GIT_TEST_DEFAULT_INITIAL_BRANCH_NAME
10
11
+TEST_PASSES_SANITIZE_LEAK=true
12
. ./test-lib.sh
13
14
test_expect_success setup '