daemon: remove unnecesary restriction for listener fd
Since df076bdbcc ([PATCH] GIT: Listen on IPv6 as well, if available., 2005-07-23), any file descriptor assigned to a listening socket was validated to be within the range to be used in an FDSET later. 6573faff34 (NO_IPV6 support for git daemon, 2005-09-28), moves to use poll() instead of select(), that doesn't have that restriction, so remove the original check. Signed-off-by: Carlo Marcelo Arenas Belón <carenas@gmail.com> Acked-by: Phillip Wood <phillip.wood123@gmail.com> Signed-off-by: Junio C Hamano <gitster@pobox.com>
Carlo Marcelo Arenas Belón committed
Jun 26, 2025 at 02:51 UTC
0c856224d202a7ad7ece25c77038ac3cafb7d56c
1 file changed
-5
daemon.c
-5
@@ -990,11 +990,6 @@ static int setup_named_sock(char *listen_addr, int listen_port, struct socketlis
990
sockfd = socket(ai->ai_family, ai->ai_socktype, ai->ai_protocol);
991
if (sockfd < 0)
992
continue;
993
- if (sockfd >= FD_SETSIZE) {
994
- logerror("Socket descriptor too large");
995
- close(sockfd);
996
- continue;
997
- }
993
994
#ifdef IPV6_V6ONLY
995
if (ai->ai_family == AF_INET6) {