mailinfo: better parse email adresses containg parentheses
When using git-rebase, author fields containing a ')' at the last position had the close-parens character removed; the removal should be done only when it is of this form: user@host (User Name) i.e. the remainder after stripping the e-mail address part is enclosed in a parentheses pair as a whole, not for addresses like this: User Name (me) <user@host> Signed-off-by: Philippe Bruhat (BooK) <book@cpan.org> Acked-by: Lukas Sandström <lukass@etek.chalmers.se> Signed-off-by: Junio C Hamano <gitster@pobox.com>
Philippe Bruhat (BooK) committed
Jul 21, 2008 at 15:34 UTC
0d4ede9f5493f0e15fb4f799e6a4a25e36c49fd2
1 file changed
+3
-3
builtin-mailinfo.c
+3
-3
@@ -115,10 +115,10 @@ static void handle_from(const struct strbuf *from)
115
* the () pair at the end.
116
*/
117
strbuf_trim(&f);
118
- if (f.buf[0] == '(')
119
- strbuf_remove(&name, 0, 1);
120
- if (f.len && f.buf[f.len - 1] == ')')
118
+ if (f.buf[0] == '(' && f.len && f.buf[f.len - 1] == ')') {
119
+ strbuf_remove(&f, 0, 1);
120
strbuf_setlen(&f, f.len - 1);
121
+ }
122
123
get_sane_name(&name, &f, &email);
124
strbuf_release(&f);