Meta/cook: leave a NEEDSWORK comment
A new topic that is still not ready for 'pu' which uses a topic in flight appear in the description of the latter as "used by", even though it does not appear in the report anywhere else. Leave a note to the place where this bug happens, as I do not have time to fix it right now.
Junio C Hamano committed
Oct 30, 2017 at 15:07 UTC
0e2d29bc9cb6cda02cf3a44ddadd2af7df341ddd
1 file changed
+9
cook
+9
@@ -250,6 +250,15 @@ sub get_commit {
250
}
251
252
my $list = join("\n", map { " " . $_ } @desc);
253
+
254
+ # NEEDSWORK:
255
+ # This is done a bit too early. We grabbed all
256
+ # under refs/heads/??/* without caring if they are
257
+ # merged to 'pu' yet, and it is correct because
258
+ # we want to describe a topic that is in the old
259
+ # edition that is tentatively kicked out of 'pu'.
260
+ # However, we do not want to say a topic is used
261
+ # by a new topic that is not yet in 'pu'!
262
my $relation = describe_relation($topic{$branch});
263
$topic{$branch}{'desc'} = $head . $list;
264
if ($relation) {