ls-remote: leakfix for not clearing server_options
Ensure `server_options` is properly cleared using `string_list_clear()` in `builtin/ls-remote.c:cmd_ls_remote`. Although we cannot yet enable `TEST_PASSES_SANITIZE_LEAK=true` for `t/t5702-protocol-v2.sh` due to other existing leaks, this fix ensures that "git-ls-remote" related server options tests pass the sanitize leak check: ... ok 12 - server-options are sent when using ls-remote ok 13 - server-options from configuration are used by ls-remote ... Signed-off-by: Xing Xin <xingxin.xx@bytedance.com> Reviewed-by: Patrick Steinhardt <ps@pks.im> Signed-off-by: Junio C Hamano <gitster@pobox.com>
Xing Xin committed
Oct 8, 2024 at 03:38 UTC
0f490d270aa015f0bcb6a99c666eaa5b83f5d375
1 file changed
+1
builtin/ls-remote.c
+1
@@ -173,5 +173,6 @@ int cmd_ls_remote(int argc,
173
transport_ls_refs_options_release(&transport_options);
174
175
strvec_clear(&pattern);
176
+ string_list_clear(&server_options, 0);
177
return status;
178
}