@matheusbsbs / matheus-bagliano / commits / 0f54b7d09a
Fork 0

gitweb/gitweb.perl: remove use of qw(...) as parentheses

Using the qw(...) construct as implicit parentheses was deprecated in perl 5.13.5. Change the relevant code in gitweb to not use the deprecated construct. The offending code was introduced in 3562198b by Jakub Narebski. The issue is that perl will now warn about this: $ perl -wE 'for my $i qw(a b) { say $i }' Use of qw(...) as parentheses is deprecated at -e line 1. a b This caused gitweb.perl to warn on perl 5.13.5 and above, and these tests to fail on those perl versions: ./t9501-gitweb-standalone-http-status.sh (Wstat: 256 Tests: 11 Failed: 10) Failed tests: 2-11 Non-zero exit status: 1 ./t9502-gitweb-standalone-parse-output.sh (Wstat: 256 Tests: 10 Failed: 9) Failed tests: 2-10 Non-zero exit status: 1 Signed-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com> Acked-by: Jakub Narębski <jnareb@gmail.com> Signed-off-by: Junio C Hamano <gitster@pobox.com>

Ævar Arnfjörð Bjarmason committed Feb 19, 2011 at 15:27 UTC 0f54b7d09ac5b87c327a1e8da43bc48be98f2758
1 file changed +2 -2
gitweb/gitweb.perl
+2 -2
@@ -3501,7 +3501,7 @@ sub print_feed_meta {
3501 $href_params{'-title'} = 'log';
3502 }
3503
3504 - foreach my $format qw(RSS Atom) {
3504 + foreach my $format (qw(RSS Atom)) {
3505 my $type = lc($format);
3506 my %link_attr = (
3507 '-rel' => 'alternate',
@@ -3682,7 +3682,7 @@ sub git_footer_html {
3682 }
3683 $href_params{'-title'} ||= 'log';
3684
3685 - foreach my $format qw(RSS Atom) {
3685 + foreach my $format (qw(RSS Atom)) {
3686 $href_params{'action'} = lc($format);
3687 print $cgi->a({-href => href(%href_params),
3688 -title => "$href_params{'-title'} $format feed",