t-reftable-stack: use reftable_ref_record_equal() to compare ref records
In the current stack tests, ref records are compared for equality by sometimes using the dedicated function for ref-record comparison, reftable_ref_record_equal(), and sometimes by explicity comparing contents of the ref records. The latter method is undesired because there can exist unequal ref records with some of the contents being equal. Replace the latter instances of ref-record comparison with the former. This has the added benefit of preserving uniformity throughout the test file. Mentored-by: Patrick Steinhardt <ps@pks.im> Mentored-by: Christian Couder <chriscool@tuxfamily.org> Signed-off-by: Chandra Pratap <chandrapratap3519@gmail.com> Signed-off-by: Junio C Hamano <gitster@pobox.com>
Chandra Pratap committed
Sep 8, 2024 at 09:35 UTC
1052280136cab7698e325289f6fac2af8fd7534e
1 file changed
+2
-2
t/unit-tests/t-reftable-stack.c
+2
-2
@@ -174,7 +174,7 @@ static void t_reftable_stack_add_one(void)
174
175
err = reftable_stack_read_ref(st, ref.refname, &dest);
176
check(!err);
177
- check_str("master", dest.value.symref);
177
+ check(reftable_ref_record_equal(&ref, &dest, GIT_SHA1_RAWSZ));
178
check_int(st->readers_len, >, 0);
179
180
#ifndef GIT_WINDOWS_NATIVE
@@ -285,7 +285,7 @@ static void t_reftable_stack_transaction_api(void)
285
err = reftable_stack_read_ref(st, ref.refname, &dest);
286
check(!err);
287
check_int(REFTABLE_REF_SYMREF, ==, dest.value_type);
288
- check_str("master", dest.value.symref);
288
+ check(reftable_ref_record_equal(&ref, &dest, GIT_SHA1_RAWSZ));
289
290
reftable_ref_record_release(&dest);
291
reftable_stack_destroy(st);