gitk: Use mktemp -d to avoid predictable temporary directories
gitk uses a predictable ".gitk-tmp.$PID" pattern when generating a temporary directory. Use "mktemp -d .gitk-tmp.XXXXXX" to harden gitk against someone seeding /tmp with files matching the pid pattern. Signed-off-by: David Aguilar <davvid@gmail.com> Signed-off-by: Paul Mackerras <paulus@samba.org>
David Aguilar committed
Jun 13, 2014 at 14:43 UTC
105b5d3fbb1c00bb0aeaf9d3e0fbe26a7b1993fc
1 file changed
+2
-1
gitk
+2
-1
@@ -3503,7 +3503,8 @@ proc gitknewtmpdir {} {
3503
} else {
3504
set tmpdir $gitdir
3505
}
3506
- set gitktmpdir [file join $tmpdir [format ".gitk-tmp.%s" [pid]]]
3506
+ set gitktmpformat [file join $tmpdir ".gitk-tmp.XXXXXX"]
3507
+ set gitktmpdir [exec mktemp -d $gitktmpformat]
3508
if {[catch {file mkdir $gitktmpdir} err]} {
3509
error_popup "[mc "Error creating temporary directory %s:" $gitktmpdir] $err"
3510
unset gitktmpdir