wt-status: simplify building of summary limit argument
Use argv_array_pushf for building the number string for the option --summary-limit directly instead of using an intermediate buffer. Signed-off-by: Rene Scharfe <l.s.r@web.de> Signed-off-by: Junio C Hamano <gitster@pobox.com>
René Scharfe committed
Jun 29, 2014 at 22:55 UTC
10761eb6812bfe46c50360685916ae14859a2b85
1 file changed
+1
-3
wt-status.c
+1
-3
@@ -734,7 +734,6 @@ static void wt_status_print_changed(struct wt_status *s)
734
static void wt_status_print_submodule_summary(struct wt_status *s, int uncommitted)
735
{
736
struct child_process sm_summary;
737
- char summary_limit[64];
737
struct argv_array env = ARGV_ARRAY_INIT;
738
struct argv_array argv = ARGV_ARRAY_INIT;
739
struct strbuf cmd_stdout = STRBUF_INIT;
@@ -742,7 +741,6 @@ static void wt_status_print_submodule_summary(struct wt_status *s, int uncommitt
741
char *summary_content;
742
size_t len;
743
745
- sprintf(summary_limit, "%d", s->submodule_summary);
744
argv_array_pushf(&env, "GIT_INDEX_FILE=%s", s->index_file);
745
746
argv_array_push(&argv, "submodule");
@@ -750,7 +748,7 @@ static void wt_status_print_submodule_summary(struct wt_status *s, int uncommitt
748
argv_array_push(&argv, uncommitted ? "--files" : "--cached");
749
argv_array_push(&argv, "--for-status");
750
argv_array_push(&argv, "--summary-limit");
753
- argv_array_push(&argv, summary_limit);
751
+ argv_array_pushf(&argv, "%d", s->submodule_summary);
752
if (!uncommitted)
753
argv_array_push(&argv, s->amend ? "HEAD^" : "HEAD");
754