Remove forward declaration of an enum
According to http://c-faq.com/null/machexamp.html, sizeof(char*) != sizeof(int*) on some platforms. Since an enum could be a char or int (or long or...), knowing the size of the enum thus is important to knowing the size of a pointer to an enum, so we cannot just forward declare an enum the way we can a struct. (Also, modern C++ compilers apparently define forward declarations of an enum to either be useless because the enum was defined, or require an explicit size specifier, or be a compilation error.) Helped-by: Jonathan Nieder <jrnieder@gmail.com> Signed-off-by: Elijah Newren <newren@gmail.com> Signed-off-by: Junio C Hamano <gitster@pobox.com>
Elijah Newren committed
Aug 15, 2018 at 10:54 UTC
1076f1e454dae338cee8e48f3e69b58181e5e10a
1 file changed
+1
-1
packfile.h
+1
-1
@@ -1,12 +1,12 @@
1
#ifndef PACKFILE_H
2
#define PACKFILE_H
3
4
+#include "cache.h"
5
#include "oidset.h"
6
7
/* in object-store.h */
8
struct packed_git;
9
struct object_info;
9
-enum object_type;
10
11
/*
12
* Generate the filename to be used for a pack file with checksum "sha1" and