gitweb: fix esc_url
Earlier, 452e225 (gitweb: fix esc_param, 2009-10-13) fixed CGI escaping rules used in esc_url. A very similar logic exists in esc_param and needs to be fixed the same way. Signed-off-by: Pavan Kumar Sunkara <pavan.sss1991@gmail.com> Signed-off-by: Junio C Hamano <gitster@pobox.com>
Pavan Kumar Sunkara committed
Jul 15, 2010 at 12:59 UTC
109988f2cb00f78b746d05c40b8a8960bbb12ff8
1 file changed
+1
-2
gitweb/gitweb.perl
+1
-2
@@ -1173,8 +1173,7 @@ sub esc_param {
1173
sub esc_url {
1174
my $str = shift;
1175
return undef unless defined $str;
1176
- $str =~ s/([^A-Za-z0-9\-_.~();\/;?:@&=])/sprintf("%%%02X", ord($1))/eg;
1177
- $str =~ s/\+/%2B/g;
1176
+ $str =~ s/([^A-Za-z0-9\-_.~();\/;?:@&= ]+)/CGI::escape($1)/eg;
1177
$str =~ s/ /\+/g;
1178
return $str;
1179
}