git-p4 shouldn't attempt to store symlinks in LFS
git-p4.py would attempt to put a symlink in LFS if its file extension matched git-p4.largeFileExtensions. Git LFS doesn't store symlinks because smudge/clean filters don't handle symlinks. They never get passed to the filter process nor the smudge/clean filters, nor could that occur without a change to the protocol or command-line interface. Unless Git learned how to send them to the filters, Git LFS would have a hard time using them in any useful way. Git LFS's goal is to move large files out of the repository history, and symlinks are functionally limited to 4 KiB or a similar size on most systems. Signed-off-by: Matthew McClain <mmcclain@noprivs.com> Signed-off-by: Junio C Hamano <gitster@pobox.com>
Matthew McClain committed
Oct 18, 2023 at 19:25 UTC
10c89a02b046e67c861f226064180c4f978a9cc3
1 file changed
+4
git-p4.py
+4
@@ -1522,6 +1522,10 @@ class LargeFileSystem(object):
1522
file is stored in the large file system and handles all necessary
1523
steps.
1524
"""
1525
+ # symlinks aren't processed by smudge/clean filters
1526
+ if git_mode == "120000":
1527
+ return (git_mode, contents)
1528
+
1529
if self.exceedsLargeFileThreshold(relPath, contents) or self.hasLargeFileExtension(relPath):
1530
contentTempFile = self.generateTempFile(contents)
1531
pointer_git_mode, contents, localLargeFile = self.generatePointer(contentTempFile)