completion: remove redundant __git_compute_all_commands() call

During lazy-initialization of the lists of all commands and porcelain commands the function __git_compute_all_commands() is called twice. The relevant part of the call sequence looks like this: __git_compute_porcelain_commands() __git_compute_all_commands() <finds list of all commands uninitialized> __git_list_all_commands() <initializes list of all commands> __git_list_porcelain_commands() __git_compute_all_commands() <finds list of all commands already initialized, does nothing> <filters porcelains from list of all commands> Either one of the two calls could be removed and the initialization of both command lists would still work as a whole, but let's remove the call from __git_compute_porcelain_commands(), because this way __git_list_porcelain_commands() will keep working in itself. Signed-off-by: SZEDER Gábor <szeder@ira.uka.de> Signed-off-by: Junio C Hamano <gitster@pobox.com>

SZEDER Gábor committed May 1, 2015 at 17:48 UTC 110062a134450f402f6d2e3e78a5aabb1df821fa
1 file changed -1
contrib/completion/git-completion.bash
-1
@@ -735,7 +735,6 @@ __git_list_porcelain_commands ()
735 __git_porcelain_commands=
736 __git_compute_porcelain_commands ()
737 {
738 - __git_compute_all_commands
738 test -n "$__git_porcelain_commands" ||
739 __git_porcelain_commands=$(__git_list_porcelain_commands)
740 }