run-command: drop silent_exec_failure arg from wait_or_whine
We do not actually use this parameter; instead we complain from the child itself (for fork/exec) or from start_command (if we are using spawn on Windows). Signed-off-by: Jeff King <peff@peff.net> Signed-off-by: Junio C Hamano <gitster@pobox.com>
Jeff King committed
Nov 30, 2012 at 17:40 UTC
13274526c1fc62fd0f15fe2bc188843982f38ec9
1 file changed
+3
-4
run-command.c
+3
-4
@@ -226,7 +226,7 @@ static inline void set_cloexec(int fd)
226
fcntl(fd, F_SETFD, flags | FD_CLOEXEC);
227
}
228
229
-static int wait_or_whine(pid_t pid, const char *argv0, int silent_exec_failure)
229
+static int wait_or_whine(pid_t pid, const char *argv0)
230
{
231
int status, code = -1;
232
pid_t waiting;
@@ -432,8 +432,7 @@ fail_pipe:
432
* At this point we know that fork() succeeded, but execvp()
433
* failed. Errors have been reported to our stderr.
434
*/
435
- wait_or_whine(cmd->pid, cmd->argv[0],
436
- cmd->silent_exec_failure);
435
+ wait_or_whine(cmd->pid, cmd->argv[0]);
436
failed_errno = errno;
437
cmd->pid = -1;
438
}
@@ -538,7 +537,7 @@ fail_pipe:
537
538
int finish_command(struct child_process *cmd)
539
{
541
- return wait_or_whine(cmd->pid, cmd->argv[0], cmd->silent_exec_failure);
540
+ return wait_or_whine(cmd->pid, cmd->argv[0]);
541
}
542
543
int run_command(struct child_process *cmd)