t/t3210-pack-refs.sh: use the $( ... ) construct for command substitution
The Git CodingGuidelines prefer the $(...) construct for command substitution instead of using the backquotes `...`. The backquoted form is the traditional method for command substitution, and is supported by POSIX. However, all but the simplest uses become complicated quickly. In particular, embedded command substitutions and/or the use of double quotes require careful escaping with the backslash character. The patch was generated by: for _f in $(find . -name "*.sh") do perl -i -pe 'BEGIN{undef $/;} s/`(.+?)`/\$(\1)/smg' "${_f}" done and then carefully proof-read. Signed-off-by: Elia Pinto <gitter.spiros@gmail.com> Signed-off-by: Junio C Hamano <gitster@pobox.com>
Elia Pinto committed
Dec 22, 2015 at 16:27 UTC
13f11b95857f0679f28064bde20995b9908732d7
1 file changed
+1
-1
t/t3210-pack-refs.sh
+1
-1
@@ -27,7 +27,7 @@ SHA1=
27
test_expect_success \
28
'see if git show-ref works as expected' \
29
'git branch a &&
30
- SHA1=`cat .git/refs/heads/a` &&
30
+ SHA1=$(cat .git/refs/heads/a) &&
31
echo "$SHA1 refs/heads/a" >expect &&
32
git show-ref a >result &&
33
test_cmp expect result'