gitweb: Remove unused $hash_base parameter from normalize_link_target
...since it was decided for normalize_link_target to only mangle pathname, and do not try to check if target is present in $hash_base tree, for performance reasons. Signed-off-by: Jakub Narebski <jnareb@gmail.com> Signed-off-by: Junio C Hamano <gitster@pobox.com>
Jakub Narebski committed
May 11, 2009 at 19:45 UTC
15c54fe7aa9376de2e03045122723ebde09bfeeb
1 file changed
+2
-5
gitweb/gitweb.perl
+2
-5
@@ -3339,10 +3339,7 @@ sub git_get_link_target {
3339
# return target of link relative to top directory (top tree);
3340
# return undef if it is not possible (including absolute links).
3341
sub normalize_link_target {
3342
- my ($link_target, $basedir, $hash_base) = @_;
3343
-
3344
- # we can normalize symlink target only if $hash_base is provided
3345
- return unless $hash_base;
3342
+ my ($link_target, $basedir) = @_;
3343
3344
# absolute symlinks (beginning with '/') cannot be normalized
3345
return if (substr($link_target, 0, 1) eq '/');
@@ -3398,7 +3395,7 @@ sub git_print_tree_entry {
3395
if (S_ISLNK(oct $t->{'mode'})) {
3396
my $link_target = git_get_link_target($t->{'hash'});
3397
if ($link_target) {
3401
- my $norm_target = normalize_link_target($link_target, $basedir, $hash_base);
3398
+ my $norm_target = normalize_link_target($link_target, $basedir);
3399
if (defined $norm_target) {
3400
print " -> " .
3401
$cgi->a({-href => href(action=>"object", hash_base=>$hash_base,