t/t9700/test.pl: don't access private object members, use public access methods
This test is accessing private object members of the Test::More and Test::Builder objects. Older versions of Test::More did not implement these variables using a hash. My system complains as follows: Can't coerce array into hash at <snip>/t/t9700/test.pl line 13. BEGIN failed--compilation aborted at <snip>/t/t9700/test.pl line 15. There are public access methods available for retrieving and setting these variables, so let's use them instead. Signed-off-by: Brandon Casey <casey@nrlssc.navy.mil> Acked-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com> Signed-off-by: Junio C Hamano <gitster@pobox.com>
Brandon Casey committed
Jun 28, 2010 at 17:51 UTC
15eeb6e921a08f2565192701c6b1ee5f1cbe9753
1 file changed
+3
-3
t/t9700/test.pl
+3
-3
@@ -10,8 +10,8 @@ use Test::More qw(no_plan);
10
BEGIN {
11
# t9700-perl-git.sh kicks off our testing, so we have to go from
12
# there.
13
- Test::More->builder->{Curr_Test} = 1;
14
- Test::More->builder->{No_Ending} = 1;
13
+ Test::More->builder->current_test(1);
14
+ Test::More->builder->no_ending(1);
15
}
16
17
use Cwd;
@@ -113,7 +113,7 @@ like($last_commit, qr/^[0-9a-fA-F]{40}$/, 'rev-parse returned hash');
113
my $dir_commit = $r2->command_oneline('log', '-n1', '--pretty=format:%H', '.');
114
isnt($last_commit, $dir_commit, 'log . does not show last commit');
115
116
-printf "1..%d\n", Test::More->builder->{Curr_Test};
116
+printf "1..%d\n", Test::More->builder->current_test;
117
118
my $is_passing = eval { Test::More->is_passing };
119
exit($is_passing ? 0 : 1) unless $@ =~ /Can't locate object method/;