config: initialize opts structure in repo_read_config()
Initialize opts structure in repo_read_config(). This change fixes a crash in later commit after a new field is added to the structure. In commit 3b256228a66f8587661481ef3e08259864f3ba2a, repo_read_config() was added. It only initializes 3 fields in the opts structure. It is passed to config_with_options() and then to do_git_config_sequence(). However, do_git_config_sequence() drops the opts on the floor and calls git_config_from_file() rather than git_config_from_file_with_options(), so that may be why this hasn't been a problem in the past. Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de> Signed-off-by: Jeff Hostetler <jeffhost@microsoft.com> Signed-off-by: Junio C Hamano <gitster@pobox.com>
Jeff Hostetler committed
Apr 15, 2019 at 13:39 UTC
1703751f21d286b383c198157a1342c35ebc11b7
1 file changed
+1
-1
config.c
+1
-1
@@ -2011,7 +2011,7 @@ int git_configset_get_pathname(struct config_set *cs, const char *key, const cha
2011
/* Functions use to read configuration from a repository */
2012
static void repo_read_config(struct repository *repo)
2013
{
2014
- struct config_options opts;
2014
+ struct config_options opts = { 0 };
2015
2016
opts.respect_includes = 1;
2017
opts.commondir = repo->commondir;