sequencer: restrict scope of a formerly public function
The function to add the `exec` commands to the todo list only needed to be public API because it was not only used internally by the sequencer, but also by `git rebase --preserve-merges`. Now that that mode has been removed, we no longer need that function to be scoped publicly. Helped-by: Alban Gruin <alban.gruin@gmail.com> Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de> Reviewed-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com> Signed-off-by: Junio C Hamano <gitster@pobox.com>
Johannes Schindelin committed
Sep 7, 2021 at 21:05 UTC
17919c3585ba9df9c65ea4a5f7300543dfba5f9f
2 files changed
+2
-4
sequencer.c
+2
-2
@@ -5387,8 +5387,8 @@ int sequencer_make_script(struct repository *r, struct strbuf *out, int argc,
5387
* Add commands after pick and (series of) squash/fixup commands
5388
* in the todo list.
5389
*/
5390
-void todo_list_add_exec_commands(struct todo_list *todo_list,
5391
- struct string_list *commands)
5390
+static void todo_list_add_exec_commands(struct todo_list *todo_list,
5391
+ struct string_list *commands)
5392
{
5393
struct strbuf *buf = &todo_list->buf;
5394
size_t base_offset = buf->len;
sequencer.h
-2
@@ -160,8 +160,6 @@ int sequencer_remove_state(struct replay_opts *opts);
160
int sequencer_make_script(struct repository *r, struct strbuf *out, int argc,
161
const char **argv, unsigned flags);
162
163
-void todo_list_add_exec_commands(struct todo_list *todo_list,
164
- struct string_list *commands);
163
int complete_action(struct repository *r, struct replay_opts *opts, unsigned flags,
164
const char *shortrevisions, const char *onto_name,
165
struct commit *onto, const struct object_id *orig_head,