@matheusbsbs / matheus-bagliano / commits / 17c13069b4
Fork 0

GitHub workflow: automatically follow minor updates of setup-msbuild

It is the custom to follow minor updates of GitHub Actions automatically, by using the suffix `@v1`. Actions' maintainers will then update that `v1` ref to point to the newest. However, for `microsoft/setup-msbuild`, 889cacb6897 (ci: configure GitHub Actions for CI/PR, 2020-04-11) uses a very specific `@v1.0.0` suffix. In this instance, that is a problem: should `setup-msbuild` release a new version that intends to fix a critical bug, we won't know it, and we won't use it. Such a scenario is not theoretical. It is happening right now: https://github.blog/changelog/2020-10-01-github-actions-deprecating-set-env-and-add-path-commands Let's simplify our setup, allowing us to benefit from automatically using the newest v1.x. Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de> Signed-off-by: Junio C Hamano <gitster@pobox.com>

Johannes Schindelin committed Oct 7, 2020 at 08:17 UTC 17c13069b47e64fb3fdd4de57f87b80943be1e4d
1 file changed +1 -1
.github/workflows/main.yml
+1 -1
@@ -154,7 +154,7 @@ jobs:
154 Expand-Archive compat.zip -DestinationPath . -Force
155 Remove-Item compat.zip
156 - name: add msbuild to PATH
157 - uses: microsoft/setup-msbuild@v1.0.0
157 + uses: microsoft/setup-msbuild@v1
158 - name: copy dlls to root
159 shell: powershell
160 run: |