Use xmemdupz() in many places.
Signed-off-by: Pierre Habouzit <madcoder@debian.org> Signed-off-by: Junio C Hamano <gitster@pobox.com>
Pierre Habouzit committed
Sep 16, 2007 at 00:32 UTC
182af8343c307436bb5364309aa6d4d46fa5911d
23 files changed
+60
-197
attr.c
+1
-6
@@ -160,12 +160,7 @@ static const char *parse_attr(const char *src, int lineno, const char *cp,
160
else if (!equals)
161
e->setto = ATTR__TRUE;
162
else {
163
- char *value;
164
- int vallen = ep - equals;
165
- value = xmalloc(vallen);
166
- memcpy(value, equals+1, vallen-1);
167
- value[vallen-1] = 0;
168
- e->setto = value;
163
+ e->setto = xmemdupz(equals + 1, ep - equals - 1);
164
}
165
e->attr = git_attr(cp, len);
166
}
builtin-add.c
+2
-6
@@ -71,12 +71,8 @@ static void fill_directory(struct dir_struct *dir, const char **pathspec,
71
baselen = common_prefix(pathspec);
72
path = ".";
73
base = "";
74
- if (baselen) {
75
- char *common = xmalloc(baselen + 1);
76
- memcpy(common, *pathspec, baselen);
77
- common[baselen] = 0;
78
- path = base = common;
79
- }
74
+ if (baselen)
75
+ path = base = xmemdupz(*pathspec, baselen);
76
77
/* Read the directory and prune it */
78
read_directory(dir, path, base, baselen, pathspec);
builtin-apply.c
+2
-9
@@ -293,11 +293,7 @@ static char *find_name(const char *line, char *def, int p_value, int terminate)
293
return def;
294
}
295
296
- name = xmalloc(len + 1);
297
- memcpy(name, start, len);
298
- name[len] = 0;
299
- free(def);
300
- return name;
296
+ return xmemdupz(start, len);
297
}
298
299
static int count_slashes(const char *cp)
@@ -687,10 +683,7 @@ static char *git_header_name(char *line, int llen)
683
break;
684
}
685
if (second[len] == '\n' && !memcmp(name, second, len)) {
690
- char *ret = xmalloc(len + 1);
691
- memcpy(ret, name, len);
692
- ret[len] = 0;
693
- return ret;
686
+ return xmemdupz(name, len);
687
}
688
}
689
}
builtin-fetch--tool.c
+1
-5
@@ -222,19 +222,15 @@ static char *find_local_name(const char *remote_name, const char *refs,
222
}
223
if (!strncmp(remote_name, ref, len) && ref[len] == ':') {
224
const char *local_part = ref + len + 1;
225
- char *ret;
225
int retlen;
226
227
if (!next)
228
retlen = strlen(local_part);
229
else
230
retlen = next - local_part;
232
- ret = xmalloc(retlen + 1);
233
- memcpy(ret, local_part, retlen);
234
- ret[retlen] = 0;
231
*force_p = single_force;
232
*not_for_merge_p = not_for_merge;
237
- return ret;
233
+ return xmemdupz(local_part, retlen);
234
}
235
ref = next;
236
}
builtin-fmt-merge-msg.c
+6
-11
@@ -140,12 +140,10 @@ static int handle_line(char *line)
140
if (!strcmp(".", src) || !strcmp(src, origin)) {
141
int len = strlen(origin);
142
if (origin[0] == '\'' && origin[len - 1] == '\'') {
143
- char *new_origin = xmalloc(len - 1);
144
- memcpy(new_origin, origin + 1, len - 2);
145
- new_origin[len - 2] = 0;
146
- origin = new_origin;
147
- } else
143
+ origin = xmemdupz(origin + 1, len - 2);
144
+ } else {
145
origin = xstrdup(origin);
146
+ }
147
} else {
148
char *new_origin = xmalloc(strlen(origin) + strlen(src) + 5);
149
sprintf(new_origin, "%s of %s", origin, src);
@@ -211,14 +209,11 @@ static void shortlog(const char *name, unsigned char *sha1,
209
210
bol += 2;
211
eol = strchr(bol, '\n');
214
-
212
if (eol) {
216
- int len = eol - bol;
217
- oneline = xmalloc(len + 1);
218
- memcpy(oneline, bol, len);
219
- oneline[len] = 0;
220
- } else
213
+ oneline = xmemdupz(bol, eol - bol);
214
+ } else {
215
oneline = xstrdup(bol);
216
+ }
217
append_to_list(&subjects, oneline, NULL);
218
}
219
builtin-for-each-ref.c
+9
-31
@@ -87,7 +87,6 @@ static int used_atom_cnt, sort_atom_limit, need_tagged;
87
static int parse_atom(const char *atom, const char *ep)
88
{
89
const char *sp;
90
- char *n;
90
int i, at;
91
92
sp = atom;
@@ -120,10 +119,7 @@ static int parse_atom(const char *atom, const char *ep)
119
(sizeof *used_atom) * used_atom_cnt);
120
used_atom_type = xrealloc(used_atom_type,
121
(sizeof(*used_atom_type) * used_atom_cnt));
123
- n = xmalloc(ep - atom + 1);
124
- memcpy(n, atom, ep - atom);
125
- n[ep-atom] = 0;
126
- used_atom[at] = n;
122
+ used_atom[at] = xmemdupz(atom, ep - atom);
123
used_atom_type[at] = valid_atom[i].cmp_type;
124
return at;
125
}
@@ -305,46 +301,28 @@ static const char *find_wholine(const char *who, int wholen, const char *buf, un
301
static const char *copy_line(const char *buf)
302
{
303
const char *eol = strchr(buf, '\n');
308
- char *line;
309
- int len;
304
if (!eol)
305
return "";
312
- len = eol - buf;
313
- line = xmalloc(len + 1);
314
- memcpy(line, buf, len);
315
- line[len] = 0;
316
- return line;
306
+ return xmemdupz(buf, eol - buf);
307
}
308
309
static const char *copy_name(const char *buf)
310
{
321
- const char *eol = strchr(buf, '\n');
322
- const char *eoname = strstr(buf, " <");
323
- char *line;
324
- int len;
325
- if (!(eoname && eol && eoname < eol))
326
- return "";
327
- len = eoname - buf;
328
- line = xmalloc(len + 1);
329
- memcpy(line, buf, len);
330
- line[len] = 0;
331
- return line;
311
+ const char *cp;
312
+ for (cp = buf; *cp != '\n'; cp++) {
313
+ if (!strncmp(cp, " <", 2))
314
+ return xmemdupz(buf, cp - buf);
315
+ }
316
+ return "";
317
}
318
319
static const char *copy_email(const char *buf)
320
{
321
const char *email = strchr(buf, '<');
322
const char *eoemail = strchr(email, '>');
338
- char *line;
339
- int len;
323
if (!email || !eoemail)
324
return "";
342
- eoemail++;
343
- len = eoemail - email;
344
- line = xmalloc(len + 1);
345
- memcpy(line, email, len);
346
- line[len] = 0;
347
- return line;
325
+ return xmemdupz(email, eoemail + 1 - email);
326
}
327
328
static void grab_date(const char *buf, struct atom_value *v)
builtin-log.c
+2
-10
@@ -441,8 +441,6 @@ static const char *clean_message_id(const char *msg_id)
441
{
442
char ch;
443
const char *a, *z, *m;
444
- char *n;
445
- size_t len;
444
445
m = msg_id;
446
while ((ch = *m) && (isspace(ch) || (ch == '<')))
@@ -458,11 +456,7 @@ static const char *clean_message_id(const char *msg_id)
456
die("insane in-reply-to: %s", msg_id);
457
if (++z == m)
458
return a;
461
- len = z - a;
462
- n = xmalloc(len + 1);
463
- memcpy(n, a, len);
464
- n[len] = 0;
465
- return n;
459
+ return xmemdupz(a, z - a);
460
}
461
462
int cmd_format_patch(int argc, const char **argv, const char *prefix)
@@ -541,9 +535,7 @@ int cmd_format_patch(int argc, const char **argv, const char *prefix)
535
endpos = strchr(committer, '>');
536
if (!endpos)
537
die("bogos committer info %s\n", committer);
544
- add_signoff = xmalloc(endpos - committer + 2);
545
- memcpy(add_signoff, committer, endpos - committer + 1);
546
- add_signoff[endpos - committer + 1] = 0;
538
+ add_signoff = xmemdupz(committer, endpos - committer + 1);
539
}
540
else if (!strcmp(argv[i], "--attach")) {
541
rev.mime_boundary = git_version_string;
builtin-ls-files.c
+1
-8
@@ -299,7 +299,6 @@ static void prune_cache(const char *prefix)
299
static const char *verify_pathspec(const char *prefix)
300
{
301
const char **p, *n, *prev;
302
- char *real_prefix;
302
unsigned long max;
303
304
prev = NULL;
@@ -326,14 +325,8 @@ static const char *verify_pathspec(const char *prefix)
325
if (prefix_offset > max || memcmp(prev, prefix, prefix_offset))
326
die("git-ls-files: cannot generate relative filenames containing '..'");
327
329
- real_prefix = NULL;
328
prefix_len = max;
331
- if (max) {
332
- real_prefix = xmalloc(max + 1);
333
- memcpy(real_prefix, prev, max);
334
- real_prefix[max] = 0;
335
- }
336
- return real_prefix;
329
+ return max ? xmemdupz(prev, max) : NULL;
330
}
331
332
/*
builtin-mv.c
+1
-4
@@ -22,10 +22,7 @@ static const char **copy_pathspec(const char *prefix, const char **pathspec,
22
for (i = 0; i < count; i++) {
23
int length = strlen(result[i]);
24
if (length > 0 && result[i][length - 1] == '/') {
25
- char *without_slash = xmalloc(length);
26
- memcpy(without_slash, result[i], length - 1);
27
- without_slash[length - 1] = '\0';
28
- result[i] = without_slash;
25
+ result[i] = xmemdupz(result[i], length - 1);
26
}
27
if (base_name) {
28
const char *last_slash = strrchr(result[i], '/');
builtin-revert.c
+1
-3
@@ -168,9 +168,7 @@ static void set_author_ident_env(const char *message)
168
char *line, *pend, *email, *timestamp;
169
170
p += 7;
171
- line = xmalloc(eol + 1 - p);
172
- memcpy(line, p, eol - p);
173
- line[eol - p] = '\0';
171
+ line = xmemdupz(p, eol - p);
172
email = strchr(line, '<');
173
if (!email)
174
die ("Could not extract author email from %s",
builtin-shortlog.c
+2
-9
@@ -39,10 +39,7 @@ static void insert_author_oneline(struct path_list *list,
39
while (authorlen > 0 && isspace(author[authorlen - 1]))
40
authorlen--;
41
42
- buffer = xmalloc(authorlen + 1);
43
- memcpy(buffer, author, authorlen);
44
- buffer[authorlen] = '\0';
45
-
42
+ buffer = xmemdupz(author, authorlen);
43
item = path_list_insert(buffer, list);
44
if (item->util == NULL)
45
item->util = xcalloc(1, sizeof(struct path_list));
@@ -66,13 +63,9 @@ static void insert_author_oneline(struct path_list *list,
63
oneline++;
64
onelinelen--;
65
}
69
-
66
while (onelinelen > 0 && isspace(oneline[onelinelen - 1]))
67
onelinelen--;
72
-
73
- buffer = xmalloc(onelinelen + 1);
74
- memcpy(buffer, oneline, onelinelen);
75
- buffer[onelinelen] = '\0';
68
+ buffer = xmemdupz(oneline, onelinelen);
69
70
if (dot3) {
71
int dot3len = strlen(dot3);
commit.c
+6
-10
@@ -628,11 +628,7 @@ static char *get_header(const struct commit *commit, const char *key)
628
if (eol - line > key_len &&
629
!strncmp(line, key, key_len) &&
630
line[key_len] == ' ') {
631
- int len = eol - line - key_len;
632
- char *ret = xmalloc(len);
633
- memcpy(ret, line + key_len + 1, len - 1);
634
- ret[len - 1] = '\0';
635
- return ret;
631
+ return xmemdupz(line + key_len + 1, eol - line - key_len - 1);
632
}
633
line = next;
634
}
@@ -709,7 +705,7 @@ static void fill_person(struct interp *table, const char *msg, int len)
705
start = end + 1;
706
while (end > 0 && isspace(msg[end - 1]))
707
end--;
712
- table[0].value = xstrndup(msg, end);
708
+ table[0].value = xmemdupz(msg, end);
709
710
if (start >= len)
711
return;
@@ -721,7 +717,7 @@ static void fill_person(struct interp *table, const char *msg, int len)
717
if (end >= len)
718
return;
719
724
- table[1].value = xstrndup(msg + start, end - start);
720
+ table[1].value = xmemdupz(msg + start, end - start);
721
722
/* parse date */
723
for (start = end + 1; start < len && isspace(msg[start]); start++)
@@ -732,7 +728,7 @@ static void fill_person(struct interp *table, const char *msg, int len)
728
if (msg + start == ep)
729
return;
730
735
- table[5].value = xstrndup(msg + start, ep - (msg + start));
731
+ table[5].value = xmemdupz(msg + start, ep - (msg + start));
732
733
/* parse tz */
734
for (start = ep - msg + 1; start < len && isspace(msg[start]); start++)
@@ -859,7 +855,7 @@ void format_commit_message(const struct commit *commit,
855
; /* do nothing */
856
857
if (state == SUBJECT) {
862
- table[ISUBJECT].value = xstrndup(msg + i, eol - i);
858
+ table[ISUBJECT].value = xmemdupz(msg + i, eol - i);
859
i = eol;
860
}
861
if (i == eol) {
@@ -875,7 +871,7 @@ void format_commit_message(const struct commit *commit,
871
msg + i + 10, eol - i - 10);
872
else if (!prefixcmp(msg + i, "encoding "))
873
table[IENCODING].value =
878
- xstrndup(msg + i + 9, eol - i - 9);
874
+ xmemdupz(msg + i + 9, eol - i - 9);
875
i = eol;
876
}
877
if (msg[i])
connect.c
+1
-3
@@ -393,9 +393,7 @@ static int git_proxy_command_options(const char *var, const char *value)
393
if (matchlen == 4 &&
394
!memcmp(value, "none", 4))
395
matchlen = 0;
396
- git_proxy_command = xmalloc(matchlen + 1);
397
- memcpy(git_proxy_command, value, matchlen);
398
- git_proxy_command[matchlen] = 0;
396
+ git_proxy_command = xmemdupz(value, matchlen);
397
}
398
return 0;
399
}
convert.c
+1
-6
@@ -323,13 +323,8 @@ static int read_convert_config(const char *var, const char *value)
323
if (!strncmp(drv->name, name, namelen) && !drv->name[namelen])
324
break;
325
if (!drv) {
326
- char *namebuf;
326
drv = xcalloc(1, sizeof(struct convert_driver));
328
- namebuf = xmalloc(namelen + 1);
329
- memcpy(namebuf, name, namelen);
330
- namebuf[namelen] = 0;
331
- drv->name = namebuf;
332
- drv->next = NULL;
327
+ drv->name = xmemdupz(name, namelen);
328
*user_convert_tail = drv;
329
user_convert_tail = &(drv->next);
330
}
diff.c
+2
-11
@@ -83,13 +83,8 @@ static int parse_lldiff_command(const char *var, const char *ep, const char *val
83
if (!strncmp(drv->name, name, namelen) && !drv->name[namelen])
84
break;
85
if (!drv) {
86
- char *namebuf;
86
drv = xcalloc(1, sizeof(struct ll_diff_driver));
88
- namebuf = xmalloc(namelen + 1);
89
- memcpy(namebuf, name, namelen);
90
- namebuf[namelen] = 0;
91
- drv->name = namebuf;
92
- drv->next = NULL;
87
+ drv->name = xmemdupz(name, namelen);
88
if (!user_diff_tail)
89
user_diff_tail = &user_diff;
90
*user_diff_tail = drv;
@@ -126,12 +121,8 @@ static int parse_funcname_pattern(const char *var, const char *ep, const char *v
121
if (!strncmp(pp->name, name, namelen) && !pp->name[namelen])
122
break;
123
if (!pp) {
129
- char *namebuf;
124
pp = xcalloc(1, sizeof(*pp));
131
- namebuf = xmalloc(namelen + 1);
132
- memcpy(namebuf, name, namelen);
133
- namebuf[namelen] = 0;
134
- pp->name = namebuf;
125
+ pp->name = xmemdupz(name, namelen);
126
pp->next = funcname_pattern_list;
127
funcname_pattern_list = pp;
128
}
diffcore-order.c
+2
-5
@@ -48,11 +48,8 @@ static void prepare_order(const char *orderfile)
48
if (*ep == '\n') {
49
*ep = 0;
50
order[cnt] = cp;
51
- }
52
- else {
53
- order[cnt] = xmalloc(ep-cp+1);
54
- memcpy(order[cnt], cp, ep-cp);
55
- order[cnt][ep-cp] = 0;
51
+ } else {
52
+ order[cnt] = xmemdupz(cp, ep - cp);
53
}
54
cnt++;
55
}
fast-import.c
+1
-3
@@ -1864,9 +1864,7 @@ static void file_change_cr(struct branch *b, int rename)
1864
endp = strchr(s, ' ');
1865
if (!endp)
1866
die("Missing space after source: %s", command_buf.buf);
1867
- s_uq = xmalloc(endp - s + 1);
1868
- memcpy(s_uq, s, endp - s);
1869
- s_uq[endp - s] = 0;
1867
+ s_uq = xmemdupz(s, endp - s);
1868
}
1869
s = s_uq;
1870
http-push.c
+2
-7
@@ -1271,10 +1271,7 @@ xml_cdata(void *userData, const XML_Char *s, int len)
1271
{
1272
struct xml_ctx *ctx = (struct xml_ctx *)userData;
1273
free(ctx->cdata);
1274
- ctx->cdata = xmalloc(len + 1);
1275
- /* NB: 's' is not null-terminated, can not use strlcpy here */
1276
- memcpy(ctx->cdata, s, len);
1277
- ctx->cdata[len] = '\0';
1274
+ ctx->cdata = xmemdupz(s, len);
1275
}
1276
1277
static struct remote_lock *lock_remote(const char *path, long timeout)
@@ -2172,9 +2169,7 @@ static void fetch_symref(const char *path, char **symref, unsigned char *sha1)
2169
2170
/* If it's a symref, set the refname; otherwise try for a sha1 */
2171
if (!prefixcmp((char *)buffer.buffer, "ref: ")) {
2175
- *symref = xmalloc(buffer.posn - 5);
2176
- memcpy(*symref, (char *)buffer.buffer + 5, buffer.posn - 6);
2177
- (*symref)[buffer.posn - 6] = '\0';
2172
+ *symref = xmemdupz((char *)buffer.buffer + 5, buffer.posn - 6);
2173
} else {
2174
get_sha1_hex(buffer.buffer, sha1);
2175
}
imap-send.c
+5
-15
@@ -623,9 +623,7 @@ parse_imap_list_l( imap_t *imap, char **sp, list_t **curp, int level )
623
goto bail;
624
cur->len = s - p;
625
s++;
626
- cur->val = xmalloc( cur->len + 1 );
627
- memcpy( cur->val, p, cur->len );
628
- cur->val[cur->len] = 0;
626
+ cur->val = xmemdupz(p, cur->len);
627
} else {
628
/* atom */
629
p = s;
@@ -633,12 +631,10 @@ parse_imap_list_l( imap_t *imap, char **sp, list_t **curp, int level )
631
if (level && *s == ')')
632
break;
633
cur->len = s - p;
636
- if (cur->len == 3 && !memcmp ("NIL", p, 3))
634
+ if (cur->len == 3 && !memcmp ("NIL", p, 3)) {
635
cur->val = NIL;
638
- else {
639
- cur->val = xmalloc( cur->len + 1 );
640
- memcpy( cur->val, p, cur->len );
641
- cur->val[cur->len] = 0;
636
+ } else {
637
+ cur->val = xmemdupz(p, cur->len);
638
}
639
}
640
@@ -1221,13 +1217,7 @@ split_msg( msg_data_t *all_msgs, msg_data_t *msg, int *ofs )
1217
if (p)
1218
msg->len = &p[1] - data;
1219
1224
- msg->data = xmalloc( msg->len + 1 );
1225
- if (!msg->data)
1226
- return 0;
1227
-
1228
- memcpy( msg->data, data, msg->len );
1229
- msg->data[ msg->len ] = 0;
1230
-
1220
+ msg->data = xmemdupz(data, msg->len);
1221
*ofs += msg->len;
1222
return 1;
1223
}
merge-recursive.c
+4
-15
@@ -432,19 +432,15 @@ static int update_stages(const char *path, struct diff_filespec *o,
432
433
static int remove_path(const char *name)
434
{
435
- int ret, len;
435
+ int ret;
436
char *slash, *dirs;
437
438
ret = unlink(name);
439
if (ret)
440
return ret;
441
- len = strlen(name);
442
- dirs = xmalloc(len+1);
443
- memcpy(dirs, name, len);
444
- dirs[len] = '\0';
441
+ dirs = xstrdup(name);
442
while ((slash = strrchr(name, '/'))) {
443
*slash = '\0';
447
- len = slash - name;
444
if (rmdir(name) != 0)
445
break;
446
}
@@ -578,9 +574,7 @@ static void update_file_flags(const unsigned char *sha,
574
flush_buffer(fd, buf, size);
575
close(fd);
576
} else if (S_ISLNK(mode)) {
581
- char *lnk = xmalloc(size + 1);
582
- memcpy(lnk, buf, size);
583
- lnk[size] = '\0';
577
+ char *lnk = xmemdupz(buf, size);
578
mkdir_p(path, 0777);
579
unlink(path);
580
symlink(lnk, path);
@@ -872,14 +866,9 @@ static int read_merge_config(const char *var, const char *value)
866
if (!strncmp(fn->name, name, namelen) && !fn->name[namelen])
867
break;
868
if (!fn) {
875
- char *namebuf;
869
fn = xcalloc(1, sizeof(struct ll_merge_driver));
877
- namebuf = xmalloc(namelen + 1);
878
- memcpy(namebuf, name, namelen);
879
- namebuf[namelen] = 0;
880
- fn->name = namebuf;
870
+ fn->name = xmemdupz(name, namelen);
871
fn->fn = ll_ext_merge;
882
- fn->next = NULL;
872
*ll_user_merge_tail = fn;
873
ll_user_merge_tail = &(fn->next);
874
}
refs.c
+4
-8
@@ -1246,15 +1246,11 @@ int create_symref(const char *ref_target, const char *refs_heads_master,
1246
static char *ref_msg(const char *line, const char *endp)
1247
{
1248
const char *ep;
1249
- char *msg;
1250
-
1249
line += 82;
1252
- for (ep = line; ep < endp && *ep != '\n'; ep++)
1253
- ;
1254
- msg = xmalloc(ep - line + 1);
1255
- memcpy(msg, line, ep - line);
1256
- msg[ep - line] = 0;
1257
- return msg;
1250
+ ep = memchr(line, '\n', endp - line);
1251
+ if (!ep)
1252
+ ep = endp;
1253
+ return xmemdupz(line, ep - line);
1254
}
1255
1256
int read_ref_at(const char *ref, unsigned long at_time, int cnt, unsigned char *sha1, char **msg, unsigned long *cutoff_time, int *cutoff_tz, int *cutoff_cnt)
sha1_file.c
+3
-9
@@ -1491,11 +1491,8 @@ found_cache_entry:
1491
ent->lru.next->prev = ent->lru.prev;
1492
ent->lru.prev->next = ent->lru.next;
1493
delta_base_cached -= ent->size;
1494
- }
1495
- else {
1496
- ret = xmalloc(ent->size + 1);
1497
- memcpy(ret, ent->data, ent->size);
1498
- ((char *)ret)[ent->size] = 0;
1494
+ } else {
1495
+ ret = xmemdupz(ent->data, ent->size);
1496
}
1497
*type = ent->type;
1498
*base_size = ent->size;
@@ -1872,12 +1869,9 @@ void *read_sha1_file(const unsigned char *sha1, enum object_type *type,
1869
1870
co = find_cached_object(sha1);
1871
if (co) {
1875
- buf = xmalloc(co->size + 1);
1876
- memcpy(buf, co->buf, co->size);
1877
- ((char*)buf)[co->size] = 0;
1872
*type = co->type;
1873
*size = co->size;
1880
- return buf;
1874
+ return xmemdupz(co->buf, co->size);
1875
}
1876
1877
buf = read_packed_sha1(sha1, type, size);
tag.c
+1
-3
@@ -68,9 +68,7 @@ int parse_tag_buffer(struct tag *item, void *data, unsigned long size)
68
memcpy(type, type_line + 5, typelen);
69
type[typelen] = '\0';
70
taglen = sig_line - tag_line - strlen("tag \n");
71
- item->tag = xmalloc(taglen + 1);
72
- memcpy(item->tag, tag_line + 4, taglen);
73
- item->tag[taglen] = '\0';
71
+ item->tag = xmemdupz(tag_line + 4, taglen);
72
73
if (!strcmp(type, blob_type)) {
74
item->tagged = &lookup_blob(sha1)->object;