t1450: clean up sub-objects in duplicate-entry test

This test creates a multi-level set of trees, but its cleanup routine only removes the top-level tree. After the test finishes, the inner tree and the blob it points to remain, making the inner tree dangling. A later test ("cleaned up") verifies that we've removed any cruft and "git fsck" output is clean. This passes only because of a bug in git-fsck which fails to notice dangling trees. In preparation for fixing the bug, let's teach this earlier test to clean up after itself correctly. We have to remove the inner tree (and therefore the blob, too, which becomes dangling after removing that tree). Since the setup code happens inside a subshell, we can't just set a variable for each object. However, we can stuff all of the sha1s into the $T output variable, which is not used for anything except cleanup. Signed-off-by: Jeff King <peff@peff.net> Signed-off-by: Junio C Hamano <gitster@pobox.com>

Jeff King committed Jan 16, 2017 at 16:24 UTC 1ada11ee62658ff4366d93b97995eea055827171
1 file changed +3 -1
t/t1450-fsck.sh
+3 -1
@@ -189,14 +189,16 @@ test_expect_success 'commit with NUL in header' '
189 '
190
191 test_expect_success 'tree object with duplicate entries' '
192 - test_when_finished "remove_object \$T" &&
192 + test_when_finished "for i in \$T; do remove_object \$i; done" &&
193 T=$(
194 GIT_INDEX_FILE=test-index &&
195 export GIT_INDEX_FILE &&
196 rm -f test-index &&
197 >x &&
198 git add x &&
199 + git rev-parse :x &&
200 T=$(git write-tree) &&
201 + echo $T &&
202 (
203 git cat-file tree $T &&
204 git cat-file tree $T