git-remote-mediawiki: always end a subroutine with a return
Follow Subroutines::RequireFinalReturn Signed-off-by: Célestin Matte <celestin.matte@ensimag.fr> Signed-off-by: Matthieu Moy <matthieu.moy@grenoble-inp.fr> Signed-off-by: Junio C Hamano <gitster@pobox.com>
Célestin Matte committed
Jun 14, 2013 at 15:50 UTC
1aff8c627baf7f313820b5e5629266b48a6e4576
1 file changed
+18
contrib/mw-to-git/git-remote-mediawiki.perl
+18
@@ -187,6 +187,7 @@ sub mw_connect_maybe {
187
exit 1;
188
}
189
}
190
+ return;
191
}
192
193
sub fatal_mw_error {
@@ -209,6 +210,7 @@ sub fatal_mw_error {
210
sub get_mw_tracked_pages {
211
my $pages = shift;
212
get_mw_page_list(\@tracked_pages, $pages);
213
+ return;
214
}
215
216
sub get_mw_page_list {
@@ -224,6 +226,7 @@ sub get_mw_page_list {
226
get_mw_first_pages(\@slice, $pages);
227
@some_pages = @some_pages[51..$#some_pages];
228
}
229
+ return;
230
}
231
232
sub get_mw_tracked_categories {
@@ -246,6 +249,7 @@ sub get_mw_tracked_categories {
249
$pages->{$page->{title}} = $page;
250
}
251
}
252
+ return;
253
}
254
255
sub get_mw_all_pages {
@@ -262,6 +266,7 @@ sub get_mw_all_pages {
266
foreach my $page (@{$mw_pages}) {
267
$pages->{$page->{title}} = $page;
268
}
269
+ return;
270
}
271
272
# queries the wiki for a set of pages. Meant to be used within a loop
@@ -289,6 +294,7 @@ sub get_mw_first_pages {
294
$pages->{$page->{title}} = $page;
295
}
296
}
297
+ return;
298
}
299
300
# Get the list of pages to be fetched according to configuration.
@@ -357,6 +363,7 @@ sub get_all_mediafiles {
363
foreach my $page (@{$mw_pages}) {
364
$pages->{$page->{title}} = $page;
365
}
366
+ return;
367
}
368
369
sub get_linked_mediafiles {
@@ -403,6 +410,7 @@ sub get_linked_mediafiles {
410
411
@titles = @titles[($batch+1)..$#titles];
412
}
413
+ return;
414
}
415
416
sub get_mw_mediafile_for_page_revision {
@@ -578,6 +586,7 @@ sub mediawiki_smudge_filename {
586
sub literal_data {
587
my ($content) = @_;
588
print STDOUT "data ", bytes::length($content), "\n", $content;
589
+ return;
590
}
591
592
sub literal_data_raw {
@@ -588,6 +597,7 @@ sub literal_data_raw {
597
binmode STDOUT, ":raw";
598
print STDOUT "data ", bytes::length($content), "\n", $content;
599
binmode STDOUT, ":encoding(UTF-8)";
600
+ return;
601
}
602
603
sub mw_capabilities {
@@ -599,6 +609,7 @@ sub mw_capabilities {
609
print STDOUT "list\n";
610
print STDOUT "push\n";
611
print STDOUT "\n";
612
+ return;
613
}
614
615
sub mw_list {
@@ -607,11 +618,13 @@ sub mw_list {
618
print STDOUT "? refs/heads/master\n";
619
print STDOUT "\@refs/heads/master HEAD\n";
620
print STDOUT "\n";
621
+ return;
622
}
623
624
sub mw_option {
625
print STDERR "remote-helper command 'option $_[0]' not yet implemented\n";
626
print STDOUT "unsupported\n";
627
+ return;
628
}
629
630
sub fetch_mw_revisions_for_page {
@@ -733,6 +746,7 @@ sub import_file_revision {
746
print STDOUT "N inline :$n\n";
747
literal_data("mediawiki_revision: " . $commit{mw_revision});
748
print STDOUT "\n\n";
749
+ return;
750
}
751
752
# parse a sequence of
@@ -753,6 +767,7 @@ sub get_more_refs {
767
die("Invalid command in a '$cmd' batch: ". $_);
768
}
769
}
770
+ return;
771
}
772
773
sub mw_import {
@@ -762,6 +777,7 @@ sub mw_import {
777
mw_import_ref($ref);
778
}
779
print STDOUT "done\n";
780
+ return;
781
}
782
783
sub mw_import_ref {
@@ -805,6 +821,7 @@ sub mw_import_ref {
821
# thrown saying that HEAD is referring to unknown object 0000000000000000000
822
# and the clone fails.
823
}
824
+ return;
825
}
826
827
sub mw_import_ref_by_pages {
@@ -1111,6 +1128,7 @@ sub mw_push {
1128
print STDERR " git pull --rebase\n";
1129
print STDERR "\n";
1130
}
1131
+ return;
1132
}
1133
1134
sub mw_push_revision {