banned.h: mark strcat() as banned
The strcat() function has all of the same overflow problems as strcpy(). And as a bonus, it's easy to end up accidentally quadratic, as each subsequent call has to walk through the existing string. The last strcat() call went away in f063d38b80 (daemon: use cld->env_array when re-spawning, 2015-09-24). In general, strcat() can be replaced either with a dynamic string (strbuf or xstrfmt), or with xsnprintf if you know the length is bounded. Signed-off-by: Jeff King <peff@peff.net> Signed-off-by: Junio C Hamano <gitster@pobox.com>
Jeff King committed
Jul 24, 2018 at 05:26 UTC
1b11b64b815db62f93a04242e4aed5687a448748
1 file changed
+2
banned.h
+2
@@ -12,5 +12,7 @@
12
13
#undef strcpy
14
#define strcpy(x,y) BANNED(strcpy)
15
+#undef strcat
16
+#define strcat(x,y) BANNED(strcat)
17
18
#endif /* BANNED_H */