parse-options.c: use exhaustive "case" arms for "enum parse_opt_result"
Change the "default" case in parse_options() that handles the return value of parse_options_step() to simply have a "case" arm for PARSE_OPT_UNKNOWN, instead of leaving it to a comment. This means the compiler can warn us about any missing case arms. This adjusts code added in ff43ec3e2d2 (parse-opt: create parse_options_step., 2008-06-23), given its age it may pre-date the existence (or widespread use) of this coding style, which we've since adopted more widely. Signed-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com> Signed-off-by: Junio C Hamano <gitster@pobox.com>
Ævar Arnfjörð Bjarmason committed
Oct 8, 2021 at 21:07 UTC
1b887353d75f62c957e04c7d6ff706142c761a4c
1 file changed
+1
-1
parse-options.c
+1
-1
@@ -866,7 +866,7 @@ enum parse_opt_result parse_options(int argc, const char **argv,
866
case PARSE_OPT_NON_OPTION:
867
case PARSE_OPT_DONE:
868
break;
869
- default: /* PARSE_OPT_UNKNOWN */
869
+ case PARSE_OPT_UNKNOWN:
870
if (ctx.argv[0][1] == '-') {
871
error(_("unknown option `%s'"), ctx.argv[0] + 2);
872
} else if (isascii(*ctx.opt)) {