t6423: add an explanation about why one of the tests does not pass
I had long since forgotten the idea behind this test and why it failed, and took a little while to figure it out. To prevent others from having to spend a similar time on it, add an explanation in the comments. However, the reasoning in the explanation makes me question why I considered it a failure at all. I'm not sure if I had a better reason when I originally wrote it, but for now just add commentary about the possible expectations and why it behaves the way it does right now. Signed-off-by: Elijah Newren <newren@gmail.com> Signed-off-by: Junio C Hamano <gitster@pobox.com>
Elijah Newren committed
Aug 10, 2020 at 22:29 UTC
1cb588775f3b5fef9c10b1f9b580521007b390ea
1 file changed
+8
t/t6423-merge-rename-directories.sh
+8
@@ -2843,6 +2843,14 @@ test_expect_success '9f: Renamed directory that only contained immediate subdirs
2843
# Commit A: priority/{alpha,bravo}/$more_files
2844
# Commit B: goal/{a,b}/$more_files, goal/c
2845
# Expected: priority/{alpha,bravo}/$more_files, priority/c
2846
+# We currently fail this test because the directory renames we detect are
2847
+# goal/a/ -> priority/alpha/
2848
+# goal/b/ -> priority/bravo/
2849
+# We do not detect
2850
+# goal/ -> priority/
2851
+# because of no files found within goal/, and the fact that "a" != "alpha"
2852
+# and "b" != "bravo". But I'm not sure it's really a failure given that
2853
+# viewpoint...
2854
2855
test_setup_9g () {
2856
test_create_repo 9g &&