t9118-git-svn-funky-branch-names.sh: use the $( ... ) construct for command substitution
The Git CodingGuidelines prefer the $(...) construct for command substitution instead of using the backquotes `...`. The backquoted form is the traditional method for command substitution, and is supported by POSIX. However, all but the simplest uses become complicated quickly. In particular, embedded command substitutions and/or the use of double quotes require careful escaping with the backslash character. The patch was generated by: for _f in $(find . -name "*.sh") do perl -i -pe 'BEGIN{undef $/;} s/`(.+?)`/\$(\1)/smg' "${_f}" done and then carefully proof-read. Signed-off-by: Elia Pinto <gitter.spiros@gmail.com> Signed-off-by: Junio C Hamano <gitster@pobox.com>
Elia Pinto committed
Jan 12, 2016 at 10:45 UTC
1d9e86f80d2ede6829c57ef4b22e4dd8b162cc7e
1 file changed
+1
-1
t/t9118-git-svn-funky-branch-names.sh
+1
-1
@@ -35,7 +35,7 @@ test_expect_success 'setup svnrepo' '
35
# SVN 1.7 will truncate "not-a%40{0]" to just "not-a".
36
# Look at what SVN wound up naming the branch and use that.
37
# Be sure to escape the @ if it shows up.
38
-non_reflog=`svn_cmd ls "$svnrepo/pr ject/branches" | grep not-a | sed 's/\///' | sed 's/@/%40/'`
38
+non_reflog=$(svn_cmd ls "$svnrepo/pr ject/branches" | grep not-a | sed 's/\///' | sed 's/@/%40/')
39
40
test_expect_success 'test clone with funky branch names' '
41
git svn clone -s "$svnrepo/pr ject" project &&