git-cvsserver: fix error for invalid password formats
Change the error message to report the erroneous password character. $1 was never set in the previos version, it was a leftover from older code that used a regex for the test. Signed-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com> Signed-off-by: Junio C Hamano <gitster@pobox.com>
Ævar Arnfjörð Bjarmason committed
Jun 19, 2010 at 16:06 UTC
1f0eb51391d58958dd9f1e6cbcba622c309303b2
1 file changed
+4
-1
git-cvsserver.perl
+4
-1
@@ -2658,7 +2658,10 @@ sub descramble
2658
2659
# This should never happen, the same password format (A) has been
2660
# used by CVS since the beginning of time
2661
- die "invalid password format $1" unless substr($str, 0, 1) eq 'A';
2661
+ {
2662
+ my $fmt = substr($str, 0, 1);
2663
+ die "invalid password format `$fmt'" unless $fmt eq 'A';
2664
+ }
2665
2666
my @str = unpack "C*", substr($str, 1);
2667
my $ret = join '', map { chr $SHIFTS[$_] } @str;