trace2: use warning() directly in tr2_dst_malformed_warning()
Let warning() format the message instead of using an intermediate strbuf for that. This is shorter, easier to read and avoids an allocation. Signed-off-by: René Scharfe <l.s.r@web.de> Signed-off-by: Junio C Hamano <gitster@pobox.com>
René Scharfe committed
Aug 25, 2019 at 19:44 UTC
1fd881d4046fb42f77ff9031ef07b7a18028ece0
1 file changed
+2
-7
trace2/tr2_dst.c
+2
-7
@@ -166,13 +166,8 @@ connected:
166
static void tr2_dst_malformed_warning(struct tr2_dst *dst,
167
const char *tgt_value)
168
{
169
- struct strbuf buf = STRBUF_INIT;
170
-
171
- strbuf_addf(&buf, "trace2: unknown value for '%s': '%s'",
172
- tr2_sysenv_display_name(dst->sysenv_var), tgt_value);
173
- warning("%s", buf.buf);
174
-
175
- strbuf_release(&buf);
169
+ warning("trace2: unknown value for '%s': '%s'",
170
+ tr2_sysenv_display_name(dst->sysenv_var), tgt_value);
171
}
172
173
int tr2_dst_get_trace_fd(struct tr2_dst *dst)