ci: remove the pipe after "p4 -V" to catch errors

When installing p4 as a dependency, we used to pipe output of "p4 -V" and "p4d -V" to validate the installation and output a condensed version information. But this would hide potential errors of p4 and would stop with an empty output. E.g.: p4d version 16.2 running on ubuntu 22.04 causes sigfaults, even before it produces any output. By removing the pipe after "p4 -V" and "p4d -V", we may get a verbose output, and stop immediately on errors because we have "set -e" in "ci/lib.sh". Since we won't look at these trace logs unless something fails, just including the raw output seems most sensible. Reviewed-by: Johannes Schindelin <johannes.schindelin@gmx.de> Helped-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com> Signed-off-by: Jiang Xin <zhiyou.jx@alibaba-inc.com> Signed-off-by: Junio C Hamano <gitster@pobox.com>

Jiang Xin committed Nov 25, 2022 at 17:59 UTC 20854bc47ae071d54f8aa71de948da5084e3adc7
1 file changed +2 -2
ci/install-dependencies.sh
+2 -2
@@ -81,9 +81,9 @@ esac
81 if type p4d >/dev/null && type p4 >/dev/null
82 then
83 echo "$(tput setaf 6)Perforce Server Version$(tput sgr0)"
84 - p4d -V | grep Rev.
84 + p4d -V
85 echo "$(tput setaf 6)Perforce Client Version$(tput sgr0)"
86 - p4 -V | grep Rev.
86 + p4 -V
87 fi
88 if type git-lfs >/dev/null
89 then