@matheusbsbs / matheus-bagliano / commits / 20e0ff8835

ci(linux32): add a note about Actions that must not be updated

The Docker container used by the `linux32` job comes without Node.js, and therefore the `actions/checkout` and `actions/upload-artifact` Actions cannot be upgraded to the latest versions (because they use Node.js). One time too many, I accidentally tried to update them, where `actions/checkout` at least fails immediately, but the `actions/upload-artifact` step is only used when any test fails, and therefore the CI run usually passes even though that Action was updated to a version that is incompatible with the Docker container in which this job runs. So let's add a big fat warning, mainly for my own benefit, to avoid running into the very same issue over and over again. Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de> Signed-off-by: Junio C Hamano <gitster@pobox.com>

Johannes Schindelin committed Feb 11, 2024 at 12:11 UTC 20e0ff883514216f5737a721443ee0dd59dbf68f

1 file changed +2 -2

.github/workflows/main.yml

+2 -2

@@ -344,7 +344,7 @@ jobs:

344 steps:

345 - uses: actions/checkout@v4

346 if: matrix.vector.jobname != 'linux32'

347 - - uses: actions/checkout@v1

347 + - uses: actions/checkout@v1 # cannot be upgraded because Node.js Actions aren't supported in this container

348 if: matrix.vector.jobname == 'linux32'

349 - run: ci/install-docker-dependencies.sh

350 - run: ci/run-build-and-tests.sh

@@ -359,7 +359,7 @@ jobs:

359 path: ${{env.FAILED_TEST_ARTIFACTS}}

360 - name: Upload failed tests' directories

361 if: failure() && env.FAILED_TEST_ARTIFACTS != '' && matrix.vector.jobname == 'linux32'

362 - uses: actions/upload-artifact@v1

362 + uses: actions/upload-artifact@v1 # cannot be upgraded because Node.js Actions aren't supported in this container

363 with:

364 name: failed-tests-${{matrix.vector.jobname}}

365 path: ${{env.FAILED_TEST_ARTIFACTS}}