@matheusbsbs / matheus-bagliano / commits / 213152688c
Fork 0

process_{tree,blob}: Remove useless xstrdup calls

On Wed, 8 Apr 2009, Björn Steinbrink wrote: > > The name of the processed object was duplicated for passing it to > add_object(), but that already calls path_name, which allocates a new > string anyway. So the memory allocated by the xstrdup calls just went > nowhere, leaking memory. Ack, ack. There's another easy 5% or so for the built-in object walker: once we've created the hash from the name, the name isn't interesting any more, and so something trivial like this can help a bit. Does it matter? Probably not on its own. But a few more memory saving tricks and it might all make a difference. Linus Signed-off-by: Junio C Hamano <gitster@pobox.com>

Linus Torvalds committed Apr 10, 2009 at 15:20 UTC 213152688c85a0e4d591abc1c10b7c279ffefb99
1 file changed +2
builtin-pack-objects.c
+2
@@ -1861,6 +1861,8 @@ static void show_object(struct object_array_entry *p)
1861 add_preferred_base_object(p->name);
1862 add_object_entry(p->item->sha1, p->item->type, p->name, 0);
1863 p->item->flags |= OBJECT_ADDED;
1864 + free((char *)p->name);
1865 + p->name = NULL;
1866 }
1867
1868 static void show_edge(struct commit *commit)