config parsing options: allow one flag multiple times

This task emerged from b04ba2bb (parse-options: deprecate OPT_BOOLEAN, 2011-09-27). This commit introduces a change for the users, after this patch you can pass one of the config level flags multiple times: Before: $ git config --global --global --list error: only one config file at a time. usage: ... Afterwards this will work. This is due to the following check in the code: if (use_global_config + use_system_config + use_local_config + !!given_config_file + !!given_config_blob > 1) { error("only one config file at a time."); usage_with_options(builtin_config_usage, builtin_config_options); } With OPT_BOOL instead of OPT_BOOLEAN the variables use_global_config, use_system_config, use_local_config will only have the value 0 if the command line option was not passed or 1 no matter how often the respective command line option was passed. Signed-off-by: Stefan Beller <stefanbeller@googlemail.com> Signed-off-by: Junio C Hamano <gitster@pobox.com>

Stefan Beller committed Aug 3, 2013 at 13:51 UTC 21e047dcadaffc09cfc958e9014e84bf2237bfe8
1 file changed +3 -3
builtin/config.c
+3 -3
@@ -50,9 +50,9 @@ static int respect_includes = -1;
50
51 static struct option builtin_config_options[] = {
52 OPT_GROUP(N_("Config file location")),
53 - OPT_BOOLEAN(0, "global", &use_global_config, N_("use global config file")),
54 - OPT_BOOLEAN(0, "system", &use_system_config, N_("use system config file")),
55 - OPT_BOOLEAN(0, "local", &use_local_config, N_("use repository config file")),
53 + OPT_BOOL(0, "global", &use_global_config, N_("use global config file")),
54 + OPT_BOOL(0, "system", &use_system_config, N_("use system config file")),
55 + OPT_BOOL(0, "local", &use_local_config, N_("use repository config file")),
56 OPT_STRING('f', "file", &given_config_file, N_("file"), N_("use given config file")),
57 OPT_STRING(0, "blob", &given_config_blob, N_("blob-id"), N_("read config from given blob object")),
58 OPT_GROUP(N_("Action")),