git-svn: do not let Git.pm warn if we prematurely close pipes
This mainly quiets down warnings when running git svn log. Signed-off-by: Eric Wong <normalperson@yhbt.net> Signed-off-by: Junio C Hamano <junkio@cox.net>
Eric Wong committed
Feb 1, 2007 at 13:12 UTC
22600a2515cc92f66fd76f2aae05637697c713b9
1 file changed
+5
-5
git-svn.perl
+5
-5
@@ -681,7 +681,7 @@ sub show_log {
681
process_commit($_, $r_min, $r_max) foreach reverse @k;
682
}
683
out:
684
- eval { command_close_pipe($log) };
684
+ close $log;
685
print '-' x72,"\n" unless $_incremental || $_oneline;
686
}
687
@@ -1475,7 +1475,7 @@ sub map_tree_joins {
1475
$seen{$commit} = 1;
1476
}
1477
}
1478
- eval { command_close_pipe($pipe) };
1478
+ close $pipe;
1479
}
1480
}
1481
@@ -1669,7 +1669,7 @@ sub write_grafts {
1669
last unless /^\S/;
1670
}
1671
}
1672
- eval { command_close_pipe($ch) }; # breaking the pipe
1672
+ close $ch; # breaking the pipe
1673
1674
# if real parents are the only ones in the grafts, drop it
1675
next if join(' ',sort keys %$p) eq join(' ',sort keys %x);
@@ -1766,7 +1766,7 @@ sub get_commit_time {
1766
} elsif ($tz =~ s/^\-//) {
1767
$s -= tz_to_s_offset($tz);
1768
}
1769
- eval { command_close_pipe($fh) };
1769
+ close $fh;
1770
return $s;
1771
}
1772
die "Can't get commit time for commit: $cmt\n";
@@ -2846,7 +2846,7 @@ sub rmdirs {
2846
delete $rm->{join '/', @dn};
2847
}
2848
unless (%$rm) {
2849
- eval { command_close_pipe($fh) };
2849
+ close $fh;
2850
return;
2851
}
2852
}